[release-4.6] Bug 1929335: Only re-create operator resource if it has existing components #2008

joelanford · 2021-02-15T19:27:31Z

This is a manual cherry-pick of #1938

/assign njhale

(This is my best impression of the openshift-cherry-pick robot's PR message 😛)

openshift-ci-robot · 2021-02-15T19:27:34Z

@joelanford: This pull request references Bugzilla bug 1899588, which is invalid:

expected the bug to target the "4.6.z" release, but it targets "---" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
expected Bugzilla bug 1899588 to depend on a bug targeting a release in 4.7.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 1899588: Only re-create operator resource if it has existing components

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

This commit fixes a bug in the operator controller that causes it to ALWAYS re-create deleted operator objects, even when no other resources associated with that operator exist. Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

…t setup order Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

njhale · 2021-02-16T00:06:07Z

/retest

I want to see if the failures are subtle flakes or somehow related (they don't look related, but we should still check).

njhale · 2021-02-16T00:06:34Z

/approve

joelanford · 2021-02-16T14:26:20Z

/retest

openshift-ci-robot · 2021-02-16T16:54:48Z

@joelanford: This pull request references Bugzilla bug 1929335, which is invalid:

expected the bug to target the "4.6.z" release, but it targets "---" instead
expected dependent Bugzilla bug 1899588 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead
expected dependent Bugzilla bug 1899588 to target a release in 4.7.0, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.6] Bug 1929335: Only re-create operator resource if it has existing components

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

joelanford · 2021-02-16T16:56:37Z

/bugzilla refresh

openshift-ci-robot · 2021-02-16T16:56:40Z

@joelanford: This pull request references Bugzilla bug 1929335, which is invalid:

expected dependent Bugzilla bug 1899588 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead
expected dependent Bugzilla bug 1899588 to target a release in 4.7.0, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

joelanford · 2021-02-16T16:57:12Z

/bugzilla refresh

openshift-ci-robot · 2021-02-16T16:57:15Z

@joelanford: This pull request references Bugzilla bug 1929335, which is invalid:

expected dependent Bugzilla bug 1899588 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dinhxuanvu · 2021-02-19T20:58:52Z

/bugzilla refresh

openshift-ci-robot · 2021-02-19T20:58:58Z

@dinhxuanvu: This pull request references Bugzilla bug 1929335, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1899588 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1899588 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dinhxuanvu

/lgtm

joelanford · 2021-02-20T00:05:13Z

Cherry-picked #2016 into this PR to avoid the flaky test making into the 4.6 branch.

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

joelanford · 2021-02-20T16:40:58Z

/test e2e-gcp

dinhxuanvu

/lgtm

openshift-ci-robot · 2021-02-22T15:34:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, joelanford, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [njhale]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

benluddy · 2021-02-25T04:25:28Z

/bugzilla refresh

openshift-ci-robot · 2021-02-25T04:25:34Z

@benluddy: This pull request references Bugzilla bug 1929335, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1899588 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1899588 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-02-25T23:14:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-02-26T01:17:03Z

@joelanford: All pull requests linked via external trackers have merged:

operator-framework/operator-lifecycle-manager#2008

Bugzilla bug 1929335 has been moved to the MODIFIED state.

In response to this:

[release-4.6] Bug 1929335: Only re-create operator resource if it has existing components

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot assigned njhale Feb 15, 2021

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Feb 15, 2021

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 15, 2021

openshift-ci-robot requested review from awgreene and hasbro17 February 15, 2021 19:27

joelanford added 5 commits February 15, 2021 14:32

Add unit tests for Operator controller deletion handling.

8e861be

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

operator_controller_test.go: use JustBeforeEach to ensure correct tes…

b1c6e2c

…t setup order Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

Address comments from PR review: added e2e, improve unit

d27a5e6

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

fix e2e test order

8c359fe

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

joelanford force-pushed the fix/zombie-operator-4.6 branch from 23af19b to 8c359fe Compare February 15, 2021 19:32

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2021

joelanford changed the title ~~[release-4.6] Bug 1899588: Only re-create operator resource if it has existing components~~ [release-4.6] Bug 1929335: Only re-create operator resource if it has existing components Feb 16, 2021

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 19, 2021

dinhxuanvu approved these changes Feb 19, 2021

View reviewed changes

openshift-ci-robot assigned dinhxuanvu Feb 19, 2021

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Feb 19, 2021

pkg/controller/operators/operator_controller_test.go: fix flaky test

4863f15

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

joelanford force-pushed the fix/zombie-operator-4.6 branch from 412866a to 4863f15 Compare February 20, 2021 13:47

dinhxuanvu approved these changes Feb 22, 2021

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2021

mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 25, 2021

openshift-merge-robot merged commit 724b6a4 into operator-framework:release-4.6 Feb 26, 2021

joelanford deleted the fix/zombie-operator-4.6 branch March 11, 2021 13:45

[release-4.6] Bug 1929335: Only re-create operator resource if it has existing components #2008

[release-4.6] Bug 1929335: Only re-create operator resource if it has existing components #2008

Uh oh!

Conversation

joelanford commented Feb 15, 2021

Uh oh!

openshift-ci-robot commented Feb 15, 2021

Uh oh!

njhale commented Feb 16, 2021

Uh oh!

njhale commented Feb 16, 2021

Uh oh!

joelanford commented Feb 16, 2021

Uh oh!

openshift-ci-robot commented Feb 16, 2021

Uh oh!

joelanford commented Feb 16, 2021

Uh oh!

openshift-ci-robot commented Feb 16, 2021

Uh oh!

joelanford commented Feb 16, 2021

Uh oh!

openshift-ci-robot commented Feb 16, 2021

Uh oh!

dinhxuanvu commented Feb 19, 2021

Uh oh!

openshift-ci-robot commented Feb 19, 2021

Uh oh!

dinhxuanvu left a comment

Choose a reason for hiding this comment

Uh oh!

joelanford commented Feb 20, 2021

Uh oh!

joelanford commented Feb 20, 2021

Uh oh!

dinhxuanvu left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Feb 22, 2021

Uh oh!

benluddy commented Feb 25, 2021

Uh oh!

openshift-ci-robot commented Feb 25, 2021

Uh oh!

openshift-bot commented Feb 25, 2021

Uh oh!

openshift-ci-robot commented Feb 26, 2021

Uh oh!

Uh oh!