🌱 Bump github.com/operator-framework/api from 0.34.0 to 0.35.0 #3670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camilamacedo86
changed the title
perdasilva
approved these changes
Oct 9, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: perdasilva The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
camilamacedo86
commented
Oct 9, 2025
| module_pkg=$(GO111MODULE="${GO111MODULE:-on}" GOWORK="${GOWORK:-off}" GOFLAGS="${GOFLAGS:-}" go list "$pkg_path") | ||
|
|
||
| GO111MODULE="${GO111MODULE:-on}" GOWORK="${GOWORK:-off}" GOFLAGS="${GOFLAGS:-}" \ | ||
| go run github.com/maxbrunsfeld/counterfeiter/v6 -o "$out" "${module_pkg}.${type_name}" |
There was a problem hiding this comment.
Add to address to fix:
Generate mocks and silence the followign warning:
WARNING: Invoking counterfeiter multiple times from "go generate" is slow.
Consider using counterfeiter:generate directives to speed things up.
See https://github.com/maxbrunsfeld/counterfeiter#step-2b---add-counterfeitergenerate-directives for more information.
Set the "COUNTERFEITER_NO_GENERATE_WARNING" environment variable to suppress this message.
COUNTERFEITER_NO_GENERATE_WARNING=1 go generate ./pkg/...
github.com/maxbrunsfeld/counterfeiter/v6/generator
../../../vendor/github.com/maxbrunsfeld/counterfeiter/v6/generator/import.go:45:17: undefined: imports.VendorlessPath
../../../vendor/github.com/maxbrunsfeld/counterfeiter/v6/generator/import.go:75:29: undefined: imports.VendorlessPath
../../../vendor/github.com/maxbrunsfeld/counterfeiter/v6/generator/loader.go:125:28: undefined: imports.VendorlessPath
pkg/api/wrappers/deployment_install_client.go:1: running "go": exit status 1
camilamacedo86
commented
Oct 9, 2025
| return ipath[len("vendor/"):] | ||
| } | ||
| return ipath | ||
| } |
There was a problem hiding this comment.
Add to address to fix:
Generate mocks and silence the followign warning:
WARNING: Invoking counterfeiter multiple times from "go generate" is slow.
Consider using counterfeiter:generate directives to speed things up.
See https://github.com/maxbrunsfeld/counterfeiter#step-2b---add-counterfeitergenerate-directives for more information.
Set the "COUNTERFEITER_NO_GENERATE_WARNING" environment variable to suppress this message.
COUNTERFEITER_NO_GENERATE_WARNING=1 go generate ./pkg/...
github.com/maxbrunsfeld/counterfeiter/v6/generator
../../../vendor/github.com/maxbrunsfeld/counterfeiter/v6/generator/import.go:45:17: undefined: imports.VendorlessPath
../../../vendor/github.com/maxbrunsfeld/counterfeiter/v6/generator/import.go:75:29: undefined: imports.VendorlessPath
../../../vendor/github.com/maxbrunsfeld/counterfeiter/v6/generator/loader.go:125:28: undefined: imports.VendorlessPath
pkg/api/wrappers/deployment_install_client.go:1: running "go": exit status 1
openshift-merge-bot
bot
merged commit 3a6fecc
into
operator-framework:master
14 checks passed
camilamacedo86
commented
Oct 10, 2025
| overlay_file=$$(mktemp "$(CURDIR)/hack/overlays/goimports_overlay.XXXXXX.json"); \ | ||
| trap 'rm -f "$$overlay_file"' EXIT; \ | ||
| printf '{\n "Replace": {\n "%s/vendor/golang.org/x/tools/imports/vendorlesspath.go": "%s/hack/overlays/goimports_vendorlesspath.go"\n }\n}\n' "$(CURDIR)" "$(CURDIR)" > "$$overlay_file"; \ | ||
| GO111MODULE=on GOWORK=off COUNTERFEITER_NO_GENERATE_WARNING=1 GOFLAGS="$$GOFLAGS -overlay=$$overlay_file" go generate ./pkg/... |
There was a problem hiding this comment.
Add to address to fix:
Generate mocks and silence the followign warning:
WARNING: Invoking counterfeiter multiple times from "go generate" is slow.
Consider using counterfeiter:generate directives to speed things up.
See https://github.com/maxbrunsfeld/counterfeiter#step-2b---add-counterfeitergenerate-directives for more information.
Set the "COUNTERFEITER_NO_GENERATE_WARNING" environment variable to suppress this message.
COUNTERFEITER_NO_GENERATE_WARNING=1 go generate ./pkg/...
github.com/maxbrunsfeld/counterfeiter/v6/generator
../../../vendor/github.com/maxbrunsfeld/counterfeiter/v6/generator/import.go:45:17: undefined: imports.VendorlessPath
../../../vendor/github.com/maxbrunsfeld/counterfeiter/v6/generator/import.go:75:29: undefined: imports.VendorlessPath
../../../vendor/github.com/maxbrunsfeld/counterfeiter/v6/generator/loader.go:125:28: undefined: imports.VendorlessPath
pkg/api/wrappers/deployment_install_client.go:1: running "go": exit status 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3666