fix(operatorgroups): write out CSV status on OperatorGroup issues #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XXL
openshift-ci-robot
added
the
approved
ecordell
reviewed
Jan 15, 2019
| @@ -236,6 +236,13 @@ The metadata section contains general metadata around the name, version and othe | |||
|
|
|||
| **Selectors** (optional): A label selector to identify related resources. Set this to select on current labels applied to this CSV object (if applicable). | |||
|
|
|||
| **InstallModes**: A set of `InstallMode`s that tell OLM which `OperatorGroup`s an Operator can belong to. An `InstallMode` consists of an `InstallModeType` and a boolean `Supported` flag. There are four `InstallModeTypes`: | |||
There was a problem hiding this comment.
I think this should mention the specific way that an operator "supports" an InstallMode - which is that it understands the OLM-written annotations on the pods
njhale
force-pushed
the
csv-installmode-status
branch
from
f453526 to
9ce8acb
Compare
ecordell
requested changes
Jan 15, 2019
- Adds 3 new CSV transition reasons: NoOperatorGroup, TooManyOperatorGroups, and UnsupportedOperatorGroup - Transitions CSVs to failed with the approriate status reason whenever an OperatorGroup issue is detected - OperatorGroup reconciliation annotates CSVs in any phase - Update InstallModes supports logic
njhale
force-pushed
the
csv-installmode-status
branch
from
9ce8acb to
efb2a2a
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ecordell
pushed a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
…-status fix(operatorgroups): write out CSV status on OperatorGroup issues
njhale
added
the
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses ALM-862 and ALM-853