Skip to content

chore(manifests): recut 0.8.1 #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2019
Merged

chore(manifests): recut 0.8.1 #771

merged 1 commit into from
Mar 21, 2019

Conversation

njhale
Copy link
Member

@njhale njhale commented Mar 20, 2019

Cut 0.8.1 pointing at new upstream image quay.io/operator-framework/olm

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 20, 2019
@njhale
Copy link
Member Author

njhale commented Mar 20, 2019

/retest

@njhale
Copy link
Member Author

njhale commented Mar 20, 2019

/hold

Looks like operatorhub.io is pointing to a different quickstart directory. Will fix.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2019
@njhale
Copy link
Member Author

njhale commented Mar 20, 2019

/hold cancel

Updated the pathing for olm.yaml to match operatorhub.io's instructions.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2019
@ecordell
Copy link
Member

/lgtm

🎉

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2019
@ecordell
Copy link
Member

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2019
@ecordell
Copy link
Member

@njhale sorry for the hold - just noticed that community operators got created in /manifests which would not be good

@njhale
Copy link
Member Author

njhale commented Mar 20, 2019

@njhale sorry for the hold - just noticed that community operators got created in /manifests which would not be good

Ahh - nice catch. I'll make sure it's removed.

@jpeeler jpeeler mentioned this pull request Mar 20, 2019
Closed
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2019
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 20, 2019
@njhale
Copy link
Member Author

njhale commented Mar 21, 2019

/retest

1 similar comment
@njhale
Copy link
Member Author

njhale commented Mar 21, 2019

/retest

@ecordell
Copy link
Member

ecordell commented Mar 21, 2019 via email

ecordell
ecordell approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 21, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, njhale

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9ee66d0 into operator-framework:master Mar 21, 2019
This was referenced Mar 21, 2019
Closed
Closed
Closed
Closed
@njhale njhale deleted the recut-0.8.1 branch September 30, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecordell ecordell ecordell approved these changes

@jpeeler jpeeler Awaiting requested review from jpeeler

Assignees

@ecordell ecordell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@njhale @ecordell @openshift-ci-robot @openshift-merge-robot