-
Notifications
You must be signed in to change notification settings - Fork 260
Add PodMonitor to supported resources #1795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PodMonitor to supported resources #1795
Conversation
PodMonitor is a useful resource when monitoring a set of Pods that do not have a dedicated Service resource associated. This is helpful if the only reason to add them to a Service would be to configure monitoring. Fixes operator-framework#1688 Signed-off-by: Moritz Wanzenböck <moritz.wanzenboeck@linbit.com>
Hi @WanzenBug. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1795 +/- ##
=======================================
Coverage 55.27% 55.27%
=======================================
Files 136 136
Lines 15976 15976
=======================================
Hits 8830 8830
Misses 5991 5991
Partials 1155 1155 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
017ab53
into
operator-framework:master
Description of the change:
Add PodMonitor to supported resources
Motivation for the change:
PodMonitor is a useful resource when monitoring a set of Pods that do not have a dedicated Service resource associated. This is helpful if the only reason to add them to a Service would be to configure monitoring.
Reviewer Checklist
/docs
Closes #1688