Skip to content

Conversation

joelanford
Copy link
Member

Description of the change:

Parameterize and use the go.mod grpc-health-probe version in the goreleaser-built quay.io/operator-framework/opm.

Motivation for the change:

This will help us keep the grpc-health-probe version up-to-date in the opm image. Dependabot is already helping us keep the grpc-health-probe go dependency up-to-date, so this PR means that that automation will now automatically propagate to the version used in the image.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

Copy link

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.27%. Comparing base (017ab53) to head (ba219cb).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1801   +/-   ##
=======================================
  Coverage   55.27%   55.27%           
=======================================
  Files         136      136           
  Lines       15976    15976           
=======================================
  Hits         8830     8830           
  Misses       5991     5991           
  Partials     1155     1155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…sion

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford force-pushed the parameterize-grpc-health-probe-version branch from 32818b4 to ba219cb Compare September 30, 2025 18:38
@tmshort
Copy link
Contributor

tmshort commented Sep 30, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 30, 2025
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

optional (nit): it might be good to add in the docs that manual docker builds now require a --build-arg to specify the GRPC_HEALTH_PROBE_VERSION

Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rashmigottipati, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a5f1128 into operator-framework:master Sep 30, 2025
13 checks passed
@joelanford joelanford deleted the parameterize-grpc-health-probe-version branch October 1, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants