Removing olm dependency #198
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/XXL
|
waiting on operator-framework/api#14 to merge first |
go.mod
Outdated
| @@ -15,7 +15,6 @@ require ( | |||
| github.com/onsi/ginkgo v1.10.1 | |||
| github.com/onsi/gomega v1.7.0 | |||
| github.com/operator-framework/api v0.0.0-20200120235816-80fd2f1a09c9 | |||
There was a problem hiding this comment.
| github.com/operator-framework/api v0.0.0-20200120235816-80fd2f1a09c9 | |
| github.com/operator-framework/api v0.1.0 |
This PR follows removing dependency olm pr operator-framework/api#14 from api repo. With api adding necessary registry dependency of olm, registry will only need to rely on api repo and remove the cyclic dependecy. Source of truth will be on api repo.
Bowenislandsong
changed the title
Bowenislandsong
force-pushed
the
resolvingCycDependency
branch
from
284333d
to
3643985
Compare
|
/lgtm |
ecordell
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bowenislandsong, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 similar comments
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bowenislandsong, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bowenislandsong, ecordell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This PR follows removing dependency olm pr operator-framework/api#14 from api repo. With api adding necessary registry dependency of olm, registry will only need to rely on api repo and remove the cyclic dependecy. Source of truth will be on api repo.
Description of the change:
Motivation for the change:
Reviewer Checklist
/docs