Skip to content

Bug 1882103: set group permissions on /etc #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2020
Merged

Bug 1882103: set group permissions on /etc #466

merged 2 commits into from
Oct 1, 2020

Conversation

ecordell
Copy link
Member

Description of the change:

Motivation for the change:

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2020
@ecordell ecordell changed the title set group permissions on /tmp set group permissions on /etc Sep 30, 2020
@jmrodri
Copy link
Member

jmrodri commented Sep 30, 2020

This PR solves the problem from Bug 1882103

INFO[0000] Running operator from directory ./jenkins-operator                                                                                                                                                                                 
INFO[0000] Creating jenkins-operator registry                                                                                                                                                                                                 
INFO[0000]   Creating ConfigMap "openshift-operator-lifecycle-manager/jenkins-operator-registry-manifests-0-3-31"                                                                                                                             
INFO[0000]   Creating ConfigMap "openshift-operator-lifecycle-manager/jenkins-operator-registry-manifests-0-4-0"                                                                                                                              
INFO[0000]   Creating ConfigMap "openshift-operator-lifecycle-manager/jenkins-operator-registry-manifests-0-4-1-rc1"                                                                                                                          
INFO[0000]   Creating ConfigMap "openshift-operator-lifecycle-manager/jenkins-operator-registry-manifests-0-4-1-rc2"                                                                                                                          
INFO[0000]   Creating ConfigMap "openshift-operator-lifecycle-manager/jenkins-operator-registry-manifests-0-4-1-rc3"                                                                                                                          
INFO[0000]   Creating ConfigMap "openshift-operator-lifecycle-manager/jenkins-operator-registry-manifests-package"                                                                                                                            
INFO[0001]   Creating ConfigMap "openshift-operator-lifecycle-manager/jenkins-operator-registry-manifests-0-2-2"                                                                                                                              
INFO[0001]   Creating Deployment "openshift-operator-lifecycle-manager/jenkins-operator-registry-server"                                                                                                                                      
INFO[0001]   Creating Service "openshift-operator-lifecycle-manager/jenkins-operator-registry-server" 
INFO[0001] Waiting for Deployment "openshift-operator-lifecycle-manager/jenkins-operator-registry-server" rollout to complete 
INFO[0001]   Waiting for Deployment "openshift-operator-lifecycle-manager/jenkins-operator-registry-server" to rollout: 0 out of 1 new replicas have been updated 
INFO[0002]   Waiting for Deployment "openshift-operator-lifecycle-manager/jenkins-operator-registry-server" to rollout: 0 of 1 updated replicas are available 
INFO[0005]   Deployment "openshift-operator-lifecycle-manager/jenkins-operator-registry-server" successfully rolled out  
INFO[0005] Creating resources                                                                                          
INFO[0005]   Creating CatalogSource "test-jenkins-operator/jenkins-operator-ocs" 
INFO[0005]   Creating Subscription "test-jenkins-operator/jenkins-operator-v0-4-1-rc3-sub" 
INFO[0005]   Creating OperatorGroup "test-jenkins-operator/operator-sdk-og" 
INFO[0005] Waiting for ClusterServiceVersion "test-jenkins-operator/jenkins-operator.v0.4.1-rc3" to reach 'Succeeded' phase 
INFO[0005]   Waiting for ClusterServiceVersion "test-jenkins-operator/jenkins-operator.v0.4.1-rc3" to appear 
INFO[0009]   Found ClusterServiceVersion "test-jenkins-operator/jenkins-operator.v0.4.1-rc3" phase: Pending 
INFO[0011]   Found ClusterServiceVersion "test-jenkins-operator/jenkins-operator.v0.4.1-rc3" phase: InstallReady 
INFO[0012]   Found ClusterServiceVersion "test-jenkins-operator/jenkins-operator.v0.4.1-rc3" phase: Installing 
INFO[0029]   Found ClusterServiceVersion "test-jenkins-operator/jenkins-operator.v0.4.1-rc3" phase: Succeeded 
INFO[0029] Successfully installed "jenkins-operator.v0.4.1-rc3" on OLM version "0.16.1" 
NAME                           NAMESPACE                KIND                        STATUS
jenkinsimages.jenkins.io       test-jenkins-operator    CustomResourceDefinition    Installed
jenkins.jenkins.io             test-jenkins-operator    CustomResourceDefinition    Installed
jenkins-operator.v0.4.1-rc3    test-jenkins-operator    ClusterServiceVersion       Installed

@jmrodri jmrodri mentioned this pull request Sep 30, 2020
Closed
5 tasks
estroz
estroz approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ecordell ecordell changed the title set group permissions on /etc Bug 1882103: set group permissions on /etc Oct 1, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Oct 1, 2020
@openshift-ci-robot
Copy link

@ecordell: This pull request references Bugzilla bug 1882103, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1882103: set group permissions on /etc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 1, 2020
@openshift-merge-robot openshift-merge-robot merged commit 9ba9df8 into master Oct 1, 2020
@openshift-ci-robot
Copy link

@ecordell: All pull requests linked via external trackers have merged:

Bugzilla bug 1882103 has been moved to the MODIFIED state.

In response to this:

Bug 1882103: set group permissions on /etc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell ecordell deleted the ecordell-patch-1 branch October 1, 2020 14:23
@prafull01 prafull01 mentioned this pull request Oct 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benluddy benluddy Awaiting requested review from benluddy

@njhale njhale Awaiting requested review from njhale

1 more reviewer

@estroz estroz estroz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@estroz estroz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ecordell @jmrodri @openshift-ci-robot @openshift-bot @estroz @openshift-merge-robot