Skip to content

OWNERS: add operator-sdk reviewers estroz, joelanford, jmrodri #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

estroz
Copy link
Member

@estroz estroz commented Oct 5, 2020

Description of the change: add @estroz, @joelanford, and @jmrodri as reviewers

Motivation for the change: operator-sdk uses a bunch of operator-registry libraries, and given its commitment to stability within major version releases would like to ensure the backwards-compatibility of these libraries. This includes contributing work that ensures compatibility.

Reviewer Checklist

  • Implementation matches the proposed design, or proposal is updated to match implementation
  • Sufficient unit test coverage
  • Sufficient end-to-end test coverage
  • Docs updated or added to /docs
  • Commit messages sensible and descriptive

@estroz
Copy link
Member Author

estroz commented Oct 5, 2020

/cc @dinhxuanvu

Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 5, 2020
@openshift-merge-robot openshift-merge-robot merged commit ea65161 into operator-framework:master Oct 5, 2020
@estroz estroz deleted the chore/sdk-owners branch July 23, 2021 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants