go test: mod flag may be set only once

[smiklosovic]

Hi,

I am trying to test my operator locally but this is the error I am hitting:

$ operator-sdk test local ./test/e2e --up-local --namespace default --go-test-flags "-timeout=20m" --debug --verbose
DEBU[0000] Debug logging is set                         
INFO[0000] Testing operator locally.                    
DEBU[0000] Running []string{"go", "test", "-mod=vendor", "./test/e2e/...", "-namespacedMan", "/tmp/empty.yaml122653018", "-globalMan", "/tmp/global-manifest.yaml427276529", "-root", "/path/tom/my/operator", "-timeout=20m", "-singleNamespace", "-parallel=1", "-localOperator"} 
go test: mod flag may be set only once
run "go help test" or "go help testflag" for more information
Error: failed to build test binary: (failed to exec []string{"go", "test", "-mod=vendor", "./test/e2e/...", "-namespacedMan", "/tmp/empty.yaml122653018", "-globalMan", "/tmp/global-manifest.yaml427276529", "-root", "//path/tom/my/operator", "-timeout=20m", "-singleNamespace", "-parallel=1", "-localOperator"}: exit status 2)

It does not matter if I set there go-test-flags or I just omit that completely, error is same.

I am on operator-sdk v0.11.0 and go 1.11.13.

[camilamacedo86]

Hi @smiklosovic,

We would need to check what Go version was supported with v0.11.0 also. Could you please use the latest version of SDK ( 0.15.x ) with go 1.13+ and let us know if you still facing any issue?

[smiklosovic]

I am trying to update to operator 0.13.0 with go 1.13.7, you guys are coding too fast! :)

[smiklosovic]

@camilamacedo86 btw there seems to be an error in 0.13 migration guide

https://github.com/operator-framework/operator-sdk/blob/master/doc/migration/version-upgrade-guide.md#modules-5

This in requires is wrong

github.com/operator-framework/operator-sdk v0.13.1

There is not such version as 0.13.1

[camilamacedo86]

It is a typo issue. It should be 0.13.0 instead of 0.13.1. Could you please collab with a PR to fix it?

[smiklosovic]

yeah I ll fix it.

I do not want to upgrade to the latest / greatest because we need to support operators on clusters as old as 1.14.x and I am not sure what happens when I bump it to 0.15.1, I have not managed to get to that yet.

[smiklosovic]

@camilamacedo86 same error with 0.13.0 and go 1.13.7

[smiklosovic]

Strangely enough, the solution is to delete vendor directory. There is the documentation about go modules in operator's docs which says that deps can be cached to vendor. I dont remember I have set that because by default it is said to be false but whatever ...

Hence having vendordir will automagically add -mod=vendor but operator framework is maybe adding more -mod flags and it fails to have multiple of them.

[camilamacedo86]

hi @smiklosovic,

The vendor/dep is no longer supported. So, yes it could cause the issue.
I am closing this one as solved. Thank you for your reply.

Please, feel free to let us know if you would like to re-open it for any reason.

[joelanford]

Just to be clear, the vendor directory is still supported.

Operator SDK detects its presence and automatically adds -mod=vendor to the go build and test commands it runs under the hood.

This may be a case where you ALSO have GOFLAGS set to include the -mod=vendor flag as well. This sounds like golang/go#32471. Can you check to see if that's the case?