Skip to content

Conversation

fanminshi
Copy link
Contributor

fixes #107

@fanminshi
Copy link
Contributor Author

fanminshi commented Mar 10, 2018

Manual Test:

$ operator-sdk new memcached-operator --api-version=cache.example.com/v1alpha1 --kind=Memcached

Run code-generation for custom resources
Generating deepcopy funcs

$ tree memcached-operator/pkg/apis/
memcached-operator/pkg/apis/
└── cache
    └── v1alpha1
        ├── doc.go
        ├── register.go
        ├── types.go
        └── zz_generated.deepcopy.go

@fanminshi
Copy link
Contributor Author

cc/ @hasbro17

@hasbro17
Copy link
Contributor

@fanminshi Did you double check that the existing operator-sdk generate k8s command still works fine as well?

@fanminshi
Copy link
Contributor Author

@hasbro17 let me double check.

@fanminshi
Copy link
Contributor Author

Yeah I checked and it still works fine.

$ operator-sdk new memcached-operator --api-version=cache.example.com/v1alpha1 --kind=Memcached

Run code-generation for custom resources
Generating deepcopy funcs

$ cd memcached-operator/

$ operator-sdk generate k8s
Run code-generation for custom resources
Generating deepcopy funcs

fanmins-MacBook-Pro:memcached-operator fanminshi$ operator-sdk build quay.io/coreos/operator-sdk-dev:memcached-operator
building memcached-operator...

building container quay.io/coreos/operator-sdk-dev:memcached-operator...
Sending build context to Docker daemon    126MB
Step 1/4 : FROM alpine:3.6
 ---> 7328f6f8b418
Step 2/4 : ADD tmp/_output/bin/memcached-operator /usr/local/bin/memcached-operator
 ---> Using cache
 ---> dfc8a3474f46
Step 3/4 : RUN adduser -D memcached-operator
 ---> Using cache
 ---> d295ab19460e
Step 4/4 : USER memcached-operator
 ---> Using cache
 ---> 8159c7fcf2a9
Successfully built 8159c7fcf2a9
Successfully tagged quay.io/coreos/operator-sdk-dev:memcached-operator

@hasbro17
Copy link
Contributor

LGTM

@fanminshi fanminshi merged commit 510e91e into operator-framework:master Mar 12, 2018
m1kola pushed a commit to m1kola/operator-sdk that referenced this pull request Jun 7, 2024
…-stamps

Bug 1943698: patch - identification of downstream sdk
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

operator-sdk new should also generate deepcopy functions for custom resource

2 participants