README: fix outputs and add logging #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanminshi
reviewed
Mar 12, 2018
| "github.com/coreos/operator-sdk/pkg/sdk/action" | ||
| "github.com/coreos/operator-sdk/pkg/sdk/handler" | ||
| "github.com/coreos/operator-sdk/pkg/sdk/types" | ||
| "github.com/sirupsen/logrus" |
There was a problem hiding this comment.
new line before "github.com/sirupsen/logrus"?
There was a problem hiding this comment.
github.com/coreos/operator-sdk/* and github.com/sirupsen/logrus are both vendored imports external to the memcached project.
I think our convention is to separate project and non-project imports.
There was a problem hiding this comment.
you are right. I somehow thought we are modifying code inside operator-sdk
|
lgtm |
|
Added the step to checkout the tag before installing SDK CLI tool. |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the README to fix a few issues and add logging to the memcached example handler to help with debugging in case someone has an issue with the example.
This gives the sample output:
/cc @fanminshi