pkg/test: remove dependence on ctx.t #1195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test library has functions that are useful outside of `go test`, such as `createFromYAML`, `ctx` resource deletion, and auto setting of resource cleanup when using the framework's client. The only function that required `t` and would fail if it did not exist was `Cleanup`, as other function could handle if it was nil. This commit removes `Cleanup`'s dependence on `t`
AlexNPavel
requested review from
estroz,
hasbro17,
joelanford,
shawn-hurley and
theishshah
openshift-ci-robot
added
the
size/S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change: This commit removes
Cleanup's dependence ont.Motivation for the change: The test library has functions that are useful outside of
go test, such ascreateFromYAML,ctxresource deletion, and auto setting of resource cleanup when using the framework's client. The only function that requiredtand would fail if it did not exist wasCleanup, as other function could handle if it was nil.