pkg/generator: change code generation on main.go and handler.go for 0.0.2 milestone #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanminshi
changed the title
|
Manual Test: $ operator-sdk new app-operator --api-version=app.example.com/v1alpha1 --kind=App
$ cd app-operator/
$ operator-sdk build quay.io/coreos/operator-sdk-dev:app-operator
$ docker push quay.io/coreos/operator-sdk-dev:app-operator
$ kubectl create -f deploy/operator.yaml
$ kubectl create -f deploy/cr.yaml
$ kubectl get po
NAME READY STATUS RESTARTS AGE
app-operator-67c6b694-2qwj8 1/1 Running 0 4m
busy-box 1/1 Running 0 4m |
fanminshi
changed the title
hasbro17
reviewed
Apr 1, 2018
pkg/generator/deploy_tmpl.go
Outdated
| kind: "{{.Kind}}" | ||
| metadata: | ||
| name: "example" | ||
| spec: |
There was a problem hiding this comment.
No need for the spec field if it's just going to be empty by default.
|
LGTM after nit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the default behavior of main.go to watch on the user defined custom resource.
change the default behavior of handler.go to create a busy-box pod when receiving a custom resource.
add auto-generation for the cr.yaml.
cc/ @hasbro17