e2e: better method of adding SDK repo replace directive to operator's go.mod #1574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
estroz
force-pushed
the
fix-e2e-modules
branch
2 times, most recently
from
187d34d to
80f29b1
Compare
joelanford
approved these changes
Jun 21, 2019
hasbro17
reviewed
Jun 26, 2019
hasbro17
reviewed
Jun 26, 2019
estroz
changed the title
estroz
added a commit
to estroz/operator-sdk
that referenced
this pull request
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change: directly add
replacedirective for the local SDK repo togo.modbytes instead of doing a bunch of extra work to usego mod edit.Motivation for the change: other dependencies may have unresolved tags/commits, ex.
kubernetes-1.14.1, in a newly-scaffoldedgo.modwhich cause errors during the parse step ofgo mod edit. Instead of doing extra replace work withsedor Go, we can skip usinggo modentirely and just add areplacedirective for the SDK repo by modifyinggo.modbytes directly.