internal/pkg/scaffold/olm-catalog: preserve certain fields, better CR/CRD updates #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions fields and use unique ID's for each owned CRD internal/util/k8sutil: more robust GetTypeMetaFromBytes instead of GetKindFromYAML
estroz
requested review from
AlexNPavel,
hasbro17,
joelanford,
lilic and
theishshah
openshift-ci-robot
added
the
size/L
|
/test marker |
|
/test e2e-aws-ansible |
|
/test e2e-aws-helm |
1 similar comment
|
/test e2e-aws-helm |
hasbro17
reviewed
Jul 18, 2019
hasbro17
reviewed
Jul 18, 2019
Co-Authored-By: Haseeb Tariq <hasbro17@gmail.com>
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
|
/test e2e-aws-helm |
2 similar comments
|
/test e2e-aws-helm |
|
/test e2e-aws-helm |
jmrodri
approved these changes
Jul 26, 2019
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
spec.customresourcedefinitions.ownedelements and use unique ID's for accessing each owned CRDGetTypeMetaFromBytes()instead ofGetKindFromYAML()Motivation for the change: users that define a
spec.customresourcedefinitions.ownedelement currently have to enter data manually (until #1162 is merged). Manually entered data should be preserved for allspec.customresourcedefinition.owneds that already exist; newly added CRD's will be appended and modified by users.