Skip to content

example: renamed handler.go to handler.go.tmpl #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2018
Merged

example: renamed handler.go to handler.go.tmpl #170

merged 1 commit into from
Apr 3, 2018

Conversation

hasbro17
Copy link
Contributor

@hasbro17 hasbro17 commented Apr 3, 2018

fixes: #168

The examples/memcahed-operator/handler.go should just be a reference example and should be ignored by dep.

/cc @fanminshi

@fanminshi
Copy link
Contributor

@hasbro17 are you going to add dep ensure in the quick start section of readme later or in this pr?

@fanminshi
Copy link
Contributor

lgtm

@hasbro17 hasbro17 merged commit 6038076 into operator-framework:master Apr 3, 2018
@hasbro17 hasbro17 deleted the haseeb/rename-examples-handler branch April 3, 2018 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dep problem on centos 7
2 participants
@hasbro17 @fanminshi