Skip to content

Conversation

estroz
Copy link
Member

@estroz estroz commented Jul 19, 2019

Description of the change: see #1535

Motivation for the change: cherry-pick for v0.8.2

* cmd/operator-sdk/build: expand env in go build

* internal/util/projutil: always append os.Environ() to go cmds

* CHANGELOG.md: add bug fix for env expansion in operator-sdk build

Co-Authored-By: Haseeb Tariq <hasbro17@gmail.com>
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 19, 2019
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

@AlexNPavel AlexNPavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estroz estroz merged commit d23727e into operator-framework:v0.8.x Jul 19, 2019
@estroz estroz deleted the pick-1535-v0.8.x branch July 19, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants