hack/tests/scaffolding/scaffold-memcached.go: always use local SDK dir in CI #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
requested review from
AlexNPavel,
fabianvf,
hasbro17,
jmrodri,
joelanford and
theishshah
openshift-ci-robot
added
the
size/M
|
/test e2e-aws-go |
| log.Fatalf("Failed to change to %s directory: (%v)", operatorName, err) | ||
| } | ||
|
|
||
| replace := getGoModReplace(localSDKPath) |
There was a problem hiding this comment.
Hi @estroz,
Could you help me understand it better? Here currently we download the PR and ensuring that the Memcached mock data will be created with. However, it is not required since the Travis will already install the PR to then call the tests. So, the goal of it is to use SDK already cloned locally by Travis instead of doing all these steps. Am I right?
If yes, its is /lgtm and /approved for me..
camilamacedo86
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change: always use the local SDK repo path in
go.modreplace lines.Motivation for the change: the CI we use will always have a local copy of the SDK repo, one merged with master. e2e tests should always use this dir so they are (mostly) CI type-agnostic.