Skip to content

go.mod,go.sum,internal/pkg/scaffold: use git.apache.org mirror #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2019
Merged

go.mod,go.sum,internal/pkg/scaffold: use git.apache.org mirror #1899

merged 1 commit into from
Oct 7, 2019

Conversation

estroz
Copy link
Member

@estroz estroz commented Sep 10, 2019

Description of the change: use github.com/apache/thrift mirror instead of git.apache.org directly.

Motivation for the change: see #1873 for details.

Closes #1873

@estroz estroz added the area/dependency Issues or PRs related to dependency changes label Sep 10, 2019
@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 10, 2019
@estroz
Copy link
Member Author

estroz commented Sep 10, 2019

/test unit
/test e2e-aws-ansible
/test e2e-aws-subcommand

@camilamacedo86
Copy link
Contributor

Testing it.

@camilamacedo86 camilamacedo86 self-assigned this Sep 11, 2019
camilamacedo86
camilamacedo86 requested changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following the steps performed to review it.

  • clone the pr
  • run $ go clean and go clean --modcache
  • make install

Then create a new project with and add the api and controller.. Check that the gen commands were executed with success.

Missing just the Changelog. 🥇

camilamacedo86
camilamacedo86 approved these changes Sep 11, 2019
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Please, before merge could you add the changelog?

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2019
@estroz
Copy link
Member Author

estroz commented Sep 11, 2019

I’m not sure this needs a changelog entry because it’s not specifically an SDK bug. @hasbro17 wdyt?

@camilamacedo86 camilamacedo86 mentioned this pull request Sep 16, 2019
Merged
hasbro17
hasbro17 reviewed Sep 16, 2019
View reviewed changes
hasbro17
hasbro17 reviewed Sep 17, 2019
View reviewed changes
@camilamacedo86 camilamacedo86 mentioned this pull request Sep 18, 2019
Closed
@estroz estroz force-pushed the fix-1873-apache-git branch from 5971290 to ffa4b55 Compare September 26, 2019 17:39
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2019
@estroz estroz force-pushed the fix-1873-apache-git branch from ffa4b55 to b93a7ae Compare September 26, 2019 17:43
@camilamacedo86
Copy link
Contributor

/test e2e-aws-helm

@estroz estroz requested a review from hasbro17 September 27, 2019 23:18
@camilamacedo86
Copy link
Contributor

Hi @estroz , @hasbro17 @jmrodri,

Any reason we do not merge it? Wdyt? Let's merge?

hasbro17
hasbro17 approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hasbro17 hasbro17 merged commit 070d931 into operator-framework:master Oct 7, 2019
@estroz estroz deleted the fix-1873-apache-git branch April 1, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@jmrodri jmrodri Awaiting requested review from jmrodri

@joelanford joelanford Awaiting requested review from joelanford

@jmccormick2001 jmccormick2001 Awaiting requested review from jmccormick2001

@fabianvf fabianvf Awaiting requested review from fabianvf

@theishshah theishshah Awaiting requested review from theishshah

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

+1 more reviewer

@hasbro17 hasbro17 hasbro17 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@camilamacedo86 camilamacedo86

Labels
area/dependency Issues or PRs related to dependency changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

operator-sdk new fails because it is unable to reach git.apache.org
4 participants
@estroz @camilamacedo86 @openshift-ci-robot @hasbro17