*: add generate alm-catalog command #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current usage: $ operator-sdk new memcached-operator --api-version=cache.example.com/v1alpha1 --kind=Memcached
...
$ operator-sdk build quay.io/example/memcached-operator:v0.0.1
$ ls deploy/alm-catalog/
crd.yaml csv.yaml package.yamlTesting out the current manifests by adding them as a new catalog entry for ALM. |
|
After some offline discussion I'm going to add a new command |
hasbro17
changed the title
|
@fanminshi PTAL. |
fanminshi
reviewed
Apr 26, 2018
pkg/generator/generator.go
Outdated
| return err | ||
| } | ||
| path := filepath.Join(almDir, catalogPackageYaml) | ||
| if err := ioutil.WriteFile(path, buf.Bytes(), defaultExecFileMode); err != nil { |
There was a problem hiding this comment.
s/defaultExecFileMode/defaultFileMode/?
Those yaml files don't need exec permissions right?
pkg/generator/generator.go
Outdated
| return err | ||
| } | ||
| path = filepath.Join(almDir, catalogCRDYaml) | ||
| if err := ioutil.WriteFile(path, buf.Bytes(), defaultExecFileMode); err != nil { |
There was a problem hiding this comment.
s/defaultExecFileMode/defaultFileMode/
pkg/generator/generator.go
Outdated
| return err | ||
| } | ||
| path = filepath.Join(almDir, catalogCSVYaml) | ||
| return ioutil.WriteFile(path, buf.Bytes(), defaultExecFileMode) |
There was a problem hiding this comment.
s/defaultExecFileMode/defaultFileMode/
| return ioutil.WriteFile(operatorYaml, buf.Bytes(), defaultFileMode) | ||
| } | ||
|
|
||
| // RenderAlmCatalog generates catalog manifests "deploy/alm-catalog/*" |
There was a problem hiding this comment.
you might want to add a comment saying that the caller must ensure that the current pwd is at the project's root path.
|
lgtm after nits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
operator-sdk generate alm-catalogcmd to generate catalog resources for ALM:The build command will now generate the following catalog resources needed to create a new catalog entry in ALM.deploy/alm-catalog/csv.yamldeploy/alm-catalog/package.yamldeploy/alm-catalog/crd.yamlThe generated CSV has minimal metadata since this is for demo purposes.
The RBAC rules in the CSV are more restricted to avoid giving admin access in a namespace but still covers enough resources to work out of the box for most operators.
The image and version of the CSV are required to be set by the flags:
A few parameters such as the CSVversionand packagechannelare fixed to default values for now since theoperator-sdk buildcommand doesn't provide enough information to set those.Later on if the catalog generation is moved into its own command the catalog resources can be more configurable e.g:
operator-sdk generate catalog --image=<image> --version=<version> .../cc @fanminshi