generator: restrict default RBAC rules #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanminshi
reviewed
Apr 27, 2018
pkg/generator/generator_test.go
Outdated
| buf := &bytes.Buffer{} | ||
| projectName := "app-operator" | ||
| if err := renderOperatorYaml(buf, "AppService", "app.example.com/v1alpha1", projectName, "quay.io/coreos/operator-sdk-dev:app-operator"); err != nil { | ||
| apiVersion := "app.example.com/v1alpha1" |
There was a problem hiding this comment.
Since you are changing this test, it probably the best refactor this to use the global test constants for app at line 23 for this test.
Also make projectName a test constant as well.
fanminshi
reviewed
Apr 27, 2018
pkg/generator/generator_test.go
Outdated
| projectName := "app-operator" | ||
| if err := renderOperatorYaml(buf, "AppService", "app.example.com/v1alpha1", projectName, "quay.io/coreos/operator-sdk-dev:app-operator"); err != nil { | ||
| apiVersion := "app.example.com/v1alpha1" | ||
| if err := renderOperatorYaml(buf, "AppService", apiVersion, projectName, "quay.io/coreos/operator-sdk-dev:app-operator"); err != nil { |
pkg/generator/generator_test.go
Outdated
|
|
||
| buf = &bytes.Buffer{} | ||
| if err := renderRBACYaml(buf, projectName); err != nil { | ||
| if err := renderRBACYaml(buf, projectName, groupName(apiVersion)); err != nil { |
There was a problem hiding this comment.
groupName(apiVersion) -> appGroupName?
| if err := renderOperatorYaml(buf, "AppService", apiVersion, projectName, "quay.io/coreos/operator-sdk-dev:app-operator"); err != nil { | ||
| t.Error(err) | ||
| } | ||
| if operatorYamlExp != buf.String() { |
There was a problem hiding this comment.
I don't think the test will pass if you don't change the expected result operatorYamlExp. You might want to update that too.
nvm.
fanminshi
reviewed
Apr 27, 2018
| if err := renderRBACYaml(buf, projectName, groupName(apiVersion)); err != nil { | ||
| t.Error(err) | ||
| } | ||
| if rbacYamlExp != buf.String() { |
There was a problem hiding this comment.
you might want to update the rbacYamlExp or else this test won't pass.
|
@fanminshi fixed. PTAL. |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #165
Restrict the default RBAC admin access rules.
Ideally the default rules should grant no privileges since the SDK does not know what resources an operator needs to access. Instead it would be expected that the user should update the RBAC manifest as needed by their operator.
However that means by default none of the operators(including our examples) would work out of the box.
So the current rules are an arbitrary middle ground to at least avoid giving admin access by default.
/cc @fanminshi