*: allow add crd to run for ansible/helm projects outside $GOPATH #2044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
|
/test e2e-aws-ansible |
2 similar comments
|
/test e2e-aws-ansible |
|
/test e2e-aws-ansible |
fabianvf
pushed a commit
to fabianvf/operator-sdk
that referenced
this pull request
Oct 14, 2019
…erator-framework#2044) * allow add crd to run for helm/ansible projects * rename GOTMP to TMPDIR for helm/ansible scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
add crdcommand to run outside$GOPATH/srcfor Helm/Ansible projects.GOTMP="$(mktemp -d -p $GOPATH/src)"==>GOTMP="$(mktemp -d)"GOTMPtoTMPDIRin the ansible/helm CI scriptsMotivation for the change:
Fix the bug introduced to
add crdin #1660The CI script var
GOTMPname change is to avoid setting it asGOTMP="$(mktemp -d -p $GOPATH/src)"since those tests shouldn't need any Go related envs/paths. This is what caused the break inadd crdto not be detected by the prow CI scripts in #1660