Implement Scorecard 2 Base Image #2837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
images/scorecard-test/bin/user_setup
Outdated
| chmod ug+rwx "${HOME}" | ||
|
|
||
| # runtime user will need to be able to self-insert in /etc/passwd | ||
| chmod g+rw /etc/passwd |
There was a problem hiding this comment.
that chmod on the passwd file is no longer needed according to Joe.
There was a problem hiding this comment.
Check #2469 out for the full set of changes. It's more than just removing this line.
added 2 commits
April 14, 2020 11:02
jmccormick2001
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create base image to support new scorecard system. Adds image build/push to Makefile (not enabled by default), a script to generate images and the base image dockerfile. Future additions will include building and executing the test binary as well as passing along test selection data to the test binary.