scorecard (alpha): use bundle labels in pod runner #3062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
requested review from
fabianvf,
jmccormick2001,
joelanford and
varshaprasad96
openshift-ci-robot
added
the
kind/feature
estroz
force-pushed
the
feature/scorecard-use-labels
branch
from
43d1234 to
bd607cc
Compare
openshift-ci-robot
added
the
needs-rebase
estroz
force-pushed
the
feature/scorecard-use-labels
branch
from
bd607cc to
01a9bac
Compare
openshift-ci-robot
removed
the
needs-rebase
estroz
force-pushed
the
feature/scorecard-use-labels
branch
from
01a9bac to
d34aedb
Compare
|
@jmccormick2001 once operator-framework/enhancements#18 is merged you can get the scorecard config path using image labels. |
estroz
force-pushed
the
feature/scorecard-use-labels
branch
from
d34aedb to
b3eb47d
Compare
estroz
force-pushed
the
feature/scorecard-use-labels
branch
from
b3eb47d to
f40aa1b
Compare
estroz
commented
Jul 6, 2020
estroz
force-pushed
the
feature/scorecard-use-labels
branch
2 times, most recently
from
ae9b976 to
eb6b2ba
Compare
varshaprasad96
approved these changes
Jul 8, 2020
|
needs labels/annotations.yaml fixed as discussed offline yesterday. |
estroz
force-pushed
the
feature/scorecard-use-labels
branch
from
eb6b2ba to
70a7a2a
Compare
|
@jmccormick2001 @varshaprasad96 fixed. The error came from not using the correct YAML library and labels not being set in the test case. |
estroz
force-pushed
the
feature/scorecard-use-labels
branch
from
70a7a2a to
a3ae768
Compare
bundle directory if no image is available internal/util/registry: operator-registry utilities, mainly label helpers
estroz
force-pushed
the
feature/scorecard-use-labels
branch
from
a3ae768 to
3b6cdf0
Compare
jmccormick2001
approved these changes
Jul 8, 2020
estroz
added a commit
to estroz/operator-sdk
that referenced
this pull request
Jul 16, 2020
…ch use image labels as the source of truth for bundle metadata if a bundle image is supplied to `scorecard`. The SDK should consider the metadata directory to contain sources of truth for bundle metadata; image labels are informative only. cmd/operator-sdk/scorecard: always use on-disk metadata images/scorecard-test/cmd/test: look up metadata using FindBundleMetadata internal/registry: remove metadata lookup functions in favor of api library functions internal/scorecard: remove 'labels' directory functionality, which is no longer needed now that metadata is always looked up recursively
2 tasks
estroz
added a commit
to estroz/operator-sdk
that referenced
this pull request
Jul 17, 2020
…ch use image labels as the source of truth for bundle metadata if a bundle image is supplied to `scorecard`. The SDK should consider the metadata directory to contain sources of truth for bundle metadata; image labels are informative only. cmd/operator-sdk/scorecard: always use on-disk metadata images/scorecard-test/cmd/test: look up metadata using FindBundleMetadata internal/registry: rewrite metadata lookup functions as FindBundleMetadata, which recursively searches for a file matching the annotations.yaml spec then returns that metadata and its path internal/scorecard: remove 'labels' directory functionality, which is no longer needed now that metadata is always looked up recursively
estroz
added a commit
to estroz/operator-sdk
that referenced
this pull request
Jul 17, 2020
…ch use image labels as the source of truth for bundle metadata if a bundle image is supplied to `scorecard`. The SDK should consider the metadata directory to contain sources of truth for bundle metadata; image labels are informative only. cmd/operator-sdk/scorecard: always use on-disk metadata images/scorecard-test/cmd/test: look up metadata using FindBundleMetadata internal/registry: rewrite metadata lookup functions as FindBundleMetadata, which recursively searches for a file matching the annotations.yaml spec then returns that metadata and its path internal/scorecard: remove 'labels' directory functionality, which is no longer needed now that metadata is always looked up recursively
estroz
added a commit
to estroz/operator-sdk
that referenced
this pull request
Jul 17, 2020
…ch use image labels as the source of truth for bundle metadata if a bundle image is supplied to `scorecard`. The SDK should consider the metadata directory to contain sources of truth for bundle metadata; image labels are informative only. cmd/operator-sdk/scorecard: always use on-disk metadata images/scorecard-test/cmd/test: look up metadata using FindBundleMetadata internal/registry: rewrite metadata lookup functions as FindBundleMetadata, which recursively searches for a file matching the annotations.yaml spec then returns that metadata and its path internal/scorecard: remove 'labels' directory functionality, which is no longer needed now that metadata is always looked up recursively
estroz
added a commit
to estroz/operator-sdk
that referenced
this pull request
Jul 17, 2020
…ch use image labels as the source of truth for bundle metadata if a bundle image is supplied to `scorecard`. The SDK should consider the metadata directory to contain sources of truth for bundle metadata; image labels are informative only. cmd/operator-sdk/scorecard: always use on-disk metadata images/scorecard-test/cmd/test: look up metadata using FindBundleMetadata internal/registry: rewrite metadata lookup functions as FindBundleMetadata, which recursively searches for a file matching the annotations.yaml spec then returns that metadata and its path internal/scorecard: remove 'labels' directory functionality, which is no longer needed now that metadata is always looked up recursively
estroz
added a commit
to estroz/operator-sdk
that referenced
this pull request
Jul 17, 2020
…ch use image labels as the source of truth for bundle metadata if a bundle image is supplied to `scorecard`. The SDK should consider the metadata directory to contain sources of truth for bundle metadata; image labels are informative only. cmd/operator-sdk/scorecard: always use on-disk metadata images/scorecard-test/cmd/test: look up metadata using FindBundleMetadata internal/registry: rewrite metadata lookup functions as FindBundleMetadata, which recursively searches for a file matching the annotations.yaml spec then returns that metadata and its path internal/scorecard: remove 'labels' directory functionality, which is no longer needed now that metadata is always looked up recursively
estroz
added a commit
to estroz/operator-sdk
that referenced
this pull request
Jul 17, 2020
…ch use image labels as the source of truth for bundle metadata if a bundle image is supplied to `scorecard`. The SDK should consider the metadata directory to contain sources of truth for bundle metadata; image labels are informative only. cmd/operator-sdk/scorecard: always use on-disk metadata images/scorecard-test/cmd/test: look up metadata using FindBundleMetadata internal/registry: rewrite metadata lookup functions as FindBundleMetadata, which recursively searches for a file matching the annotations.yaml spec then returns that metadata and its path internal/scorecard: remove 'labels' directory functionality, which is no longer needed now that metadata is always looked up recursively
estroz
added a commit
to estroz/operator-sdk
that referenced
this pull request
Jul 20, 2020
…ch use image labels as the source of truth for bundle metadata if a bundle image is supplied to `scorecard`. The SDK should consider the metadata directory to contain sources of truth for bundle metadata; image labels are informative only. cmd/operator-sdk/scorecard: always use on-disk metadata images/scorecard-test/cmd/test: look up metadata using FindBundleMetadata internal/registry: rewrite metadata lookup functions as FindBundleMetadata, which recursively searches for a file matching the annotations.yaml spec then returns that metadata and its path internal/scorecard: remove 'labels' directory functionality, which is no longer needed now that metadata is always looked up recursively
estroz
added a commit
to estroz/operator-sdk
that referenced
this pull request
Jul 20, 2020
…ch use image labels as the source of truth for bundle metadata if a bundle image is supplied to `scorecard`. The SDK should consider the metadata directory to contain sources of truth for bundle metadata; image labels are informative only. cmd/operator-sdk/scorecard: always use on-disk metadata images/scorecard-test/cmd/test: look up metadata using FindBundleMetadata internal/registry: rewrite metadata lookup functions as FindBundleMetadata, which recursively searches for a file matching the annotations.yaml spec then returns that metadata and its path internal/scorecard: remove 'labels' directory functionality, which is no longer needed now that metadata is always looked up recursively
estroz
pushed a commit
that referenced
this pull request
Jul 20, 2020
#3450) This commit reverts some changes made in #3062, which use image labels as the source of truth for bundle metadata if a bundle image is supplied to `scorecard`. The SDK should consider the metadata directory to contain sources of truth for bundle metadata; image labels are informative only. cmd/operator-sdk/scorecard: always use on-disk metadata images/scorecard-test/cmd/test: look up metadata using FindBundleMetadata internal/registry: rewrite metadata lookup functions as FindBundleMetadata, which recursively searches for a file matching the annotations.yaml spec then returns that metadata and its path internal/scorecard: remove 'labels' directory functionality, which is no longer needed now that metadata is always looked up recursively
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
helpers
Motivation for the change: the scorecard should not assume paths within a bundle image, instead it should rely on image labels if available. These changes also help implement the functionality discussed in operator-framework/enhancements#18.
/cc @jmccormick2001
/kind feature