Skip to content

*: release v1.0.0-alpha.1 #3574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 28, 2020
Merged

*: release v1.0.0-alpha.1 #3574

merged 6 commits into from
Jul 28, 2020

Conversation

jmrodri
Copy link
Member

@jmrodri jmrodri commented Jul 27, 2020

No description provided.

@joelanford
Copy link
Member

joelanford commented Jul 27, 2020 •
edited
Loading

I'm working on updating and consolidating the migration guide. Please hold reviews of that until the initial edits are made.

The above is now complete.

camilamacedo86
camilamacedo86 reviewed Jul 27, 2020
View reviewed changes
camilamacedo86
camilamacedo86 approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the version on top be alpha as well.
Otherwise, it shows /lgtm
wait for @joelanford ok as well

@joelanford joelanford changed the title *: release v1.0.0-alpha *: release v1.0.0-alpha.1 Jul 27, 2020
joelanford
joelanford requested changes Jul 27, 2020
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also bump version/version.go to v1.0.0-alpha.1

@jmrodri
Copy link
Member Author

jmrodri commented Jul 27, 2020

Need to also bump version/version.go to v1.0.0-alpha.1

It is:

$ cat version/version.go | grep Version
// Licensed under the Apache License, Version 2.0 (the "License");
        Version           = "v1.0.0-alpha.1"
        GitVersion        = "unknown"
        KubernetesVersion = "unknown"
        GoVersion         = fmt.Sprintf("%s %s/%s", runtime.Version(), runtime.GOOS, runtime.GOARCH)

@joelanford
Copy link
Member

That's what I get for scrolling right by and assuming it would be the last file in the change set!

joelanford
joelanford approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2020
joelanford
joelanford requested changes Jul 28, 2020
View reviewed changes
hasbro17
hasbro17 reviewed Jul 28, 2020
View reviewed changes
hasbro17
hasbro17 reviewed Jul 28, 2020
View reviewed changes
hasbro17
hasbro17 reviewed Jul 28, 2020
View reviewed changes
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
hasbro17
hasbro17 reviewed Jul 28, 2020
View reviewed changes
hasbro17
hasbro17 reviewed Jul 28, 2020
View reviewed changes
hasbro17
hasbro17 reviewed Jul 28, 2020
View reviewed changes
hasbro17
hasbro17 reviewed Jul 28, 2020
View reviewed changes
hasbro17
hasbro17 reviewed Jul 28, 2020
View reviewed changes
hasbro17
hasbro17 reviewed Jul 28, 2020
View reviewed changes
hasbro17
hasbro17 approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joelanford
joelanford approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@fabianvf
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2020
@jmrodri jmrodri merged commit b95f052 into operator-framework:master Jul 28, 2020
@jmrodri jmrodri deleted the alpha-release branch August 17, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

+2 more reviewers

@fabianvf fabianvf fabianvf approved these changes

@hasbro17 hasbro17 hasbro17 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@joelanford joelanford

@fabianvf fabianvf

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jmrodri @joelanford @fabianvf @hasbro17 @camilamacedo86 @openshift-ci-robot