Modify rbac role, rather than patch with kustomize #3624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ansible was creating kustomize patches to the RBAC role, which was different than the helm/go plugins. Now we simply update role.yaml more like the other plugins.
jmrodri
approved these changes
Jul 31, 2020
| cat "$ROOTDIR/test/ansible-memcached/watches-v1-kind.yaml" >> watches.yaml | ||
| echo $marker >> watches.yaml | ||
| sed -i'.bak' -e '/- secrets/a \ \ - services' config/rbac/role.yaml; rm -f config/rbac/role.yaml.bak | ||
| sed -i'.bak' -e '/- secrets/a \ \ \ \ \ \ - services' config/rbac/role.yaml; rm -f config/rbac/role.yaml.bak |
There was a problem hiding this comment.
What crazy incantation is this? :) looks fine
There was a problem hiding this comment.
yamllint didnt like the lack of indentation, so we indented the rest of the role.yaml, which means this had to be pushed over too. 🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible was creating kustomize patches to the RBAC role, which was
different than the helm/go plugins. Now we simply update role.yaml more
like the other plugins.