[olm] Remove olm-namespace flag from install sub-command #3670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove 'olm-namespace' flag from 'operator-sdk olm install' command. Reason: The OLM manifests which are used to install olm-operator have hardcoded namespace value.
estroz
reviewed
Aug 7, 2020
| @@ -35,8 +35,6 @@ func newInstallCmd() *cobra.Command { | |||
| } | |||
|
|
|||
| cmd.Flags().StringVar(&mgr.Version, "version", olm.DefaultVersion, "version of OLM resources to install") | |||
| cmd.Flags().StringVar(&mgr.OLMNamespace, "olm-namespace", olm.DefaultOLMNamespace, | |||
There was a problem hiding this comment.
mgr.OLMNamespace is still used in InstallVersion. We should remove this field from the manager's struct and pass the hard-coded default olm.
There was a problem hiding this comment.
mgr.OLMNamespace is still used by status and uninstall commands though
There was a problem hiding this comment.
m.initialize() would fill the DefaultOLMNamespace value in manager's struct. So at least for install command, the mgr.OLMNamespace would always be olm when InstallVersion is called.
estroz
approved these changes
Aug 7, 2020
|
Help looks good The flag is gone so trying to use it will print the usage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Remove 'olm-namespace' flag from 'operator-sdk olm install' command.
Motivation for the change:
The olm manifests published in github have a hardcoded
namespace value. Hence, the olm operators can only be installed in
olmnamespace using
operator-sdk olm installcommand.Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs