go/ansible/helm plugins: use rbac/v1 for metrics reader cluster role #4136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sigs.k8s.io/controller-runtime v0.6.3 | ||
| sigs.k8s.io/controller-tools v0.3.0 | ||
| sigs.k8s.io/kubebuilder v1.0.9-0.20201014221150-c993a2a221fe | ||
| sigs.k8s.io/kubebuilder v1.0.9-0.20201021204649-36124ae2e027 |
There was a problem hiding this comment.
Is it the latest version?
There was a problem hiding this comment.
It's not. This is the commit that added the fix for this particular issue after my upstream PR merged. I didn't want to pull in any more than necessary since this PR is meant to only cover the rbac/v1 scaffolding fix.
camilamacedo86
approved these changes
Oct 30, 2020
There was a problem hiding this comment.
Hi @joelanford,
I checked and shows that only your pr requires a changelog entry (kubernetes-sigs/kubebuilder@c993a2a...36124ae). So,
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
In Go, Ansible, and Helm operators, updated the
metrics-readerClusterRole to userbac.authorization.k8s.io/v1to be consistent with all other scaffolded RBAC resources.Motivation for the change:
Closes #4072
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs