Skip to content

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Dec 2, 2020

Description of the change:

  • update advanced mock static scenario with 1.0+ layout (Kubebuilder layout ansible tests, by Fabian #3433) - (note that we need to ensure that the test works with the new layout)
  • Fix CI issue (blocker master): The error was: urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='172.30.99.1', port=24443): Max retries exceeded with url: /version (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f28647cdb38>: Failed to establish a new connection: [Errno 110] Connection timed out',)) in GA.

NOTE: The follow up here is to replace the test/ansible static mock with samples to ensure that we are testing it with the latest changes always. See the issue #4025 and its PR : #4312

@camilamacedo86 camilamacedo86 changed the title fix ga to run ansible molecule e2e-tests: split molecule ansible tests Dec 5, 2020
@camilamacedo86 camilamacedo86 changed the title e2e-tests: split molecule ansible tests e2e-tests: fix advanced molecule ansible tests Dec 5, 2020
@camilamacedo86 camilamacedo86 changed the title e2e-tests: fix advanced molecule ansible tests wip: e2e-tests: fix advanced molecule ansible tests Dec 5, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 5, 2020
@camilamacedo86 camilamacedo86 changed the title wip: e2e-tests: fix advanced molecule ansible tests e2e-tests: fix advanced molecule ansible tests Dec 12, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2020
@camilamacedo86 camilamacedo86 requested review from asmacdo, estroz and fabianvf and removed request for fabianvf December 12, 2020 16:35
@camilamacedo86 camilamacedo86 changed the title e2e-tests: fix advanced molecule ansible tests WIP: e2e-tests: fix advanced molecule ansible tests Dec 13, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2020
@camilamacedo86 camilamacedo86 changed the title WIP: e2e-tests: fix advanced molecule ansible tests e2e-tests: fix advanced molecule ansible tests Dec 14, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 14, 2020
Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this test is generating a v1 sample shouldn’t it exist under testdata/ansible/memcached-molecule-operator?

Copy link
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but waiting for @fabianvf or @asmacdo to take a peek.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2020
env
export PATH=/opt/python/3.6.7/bin:${PATH}
sudo apt-get install python3 python3-pip
sudo pip3 install wheel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can this be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we only added this in the PR https://github.com/operator-framework/operator-sdk/pull/4253/files#diff-b40bad6fd0ff24f0b76e97122134b4fb2df604d6b73e4ddbd88bf5229f6c9912R34. It was not used/set before that and it's not required.

Copy link
Member

@asmacdo asmacdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@camilamacedo86 camilamacedo86 merged commit f409eb4 into operator-framework:master Dec 15, 2020
@camilamacedo86 camilamacedo86 deleted the fix-molecule branch December 15, 2020 19:18
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
**Description of the change:**
- update advanced mock static scenario with 1.0+ layout (operator-framework#3433) - (note that we need to ensure that the test works with the new layout)
- Fix CI issue (blocker master):  `The error was: urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='172.30.99.1', port=24443): Max retries exceeded with url: /version (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f28647cdb38>: Failed to establish a new connection: [Errno 110] Connection timed out',))` in GA.

NOTE: The follow up here is to replace the test/ansible static mock with samples to ensure that we are testing it with the latest changes always. See the issue operator-framework#4025 and its PR : operator-framework#4312
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants