Skip to content

Conversation

estroz
Copy link
Member

@estroz estroz commented Aug 29, 2018

fatal: write failure on 'stdout': Bad file descriptor error is encountered by some users because the call to git commit uses a nil output fd. This commit allows git commit to print to stdout but quietly, fixing the error.

Fixes #363

"fatal: write failure on 'stdout': Bad file descriptor" error is encountered by some users because the output fd is nil. This commit allows `git commit` to print to stdout but quietly. fixing the error.

Fixes operator-framework#363
@hasbro17
Copy link
Contributor

LGTM.
Btw can you share the output of what gets printed out on operator-sdk new with this.
I'm assuming with -q nothing is printed.

@estroz
Copy link
Member Author

estroz commented Aug 29, 2018

Yes, nothing prints when the binary calls git commit.

[test@test operator-sdk-samples]$ operator-sdk new test-operator --api-version=test.example.com/v1 --kind=TestService
Create test-operator/.gitignore 
...
Run dep ensure done
Run code-generation for custom resources
Generating deepcopy funcs

Run git init ...
Initialized empty Git repository in /home/test/go/src/github.com/operator-framework/operator-sdk-samples/test-operator/.git/
Run git init done

@fanminshi
Copy link
Contributor

lgtm

Copy link
Contributor

@rithujohn191 rithujohn191 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@estroz estroz merged commit dc46be1 into operator-framework:master Sep 4, 2018
@estroz estroz deleted the fix-363 branch September 4, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fatal: write failure on 'stdout': Bad file descriptor

4 participants