*: test the case where only the application TLS asset exists #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanminshi
changed the title
*: test the case when both app and CA TLS assets exist
|
fixed CI failure. PTAL |
shawn-hurley
approved these changes
Aug 30, 2018
hasbro17
reviewed
Aug 30, 2018
test/e2e/tls_util_test.go
Outdated
| } | ||
| if !reflect.DeepEqual(caSecret, actualCaSecret) { | ||
| t.Fatalf("expect %+v, got %+v", caSecret, actualCaSecret) | ||
| expErrMsg := "ca secret and configMap are not found" |
There was a problem hiding this comment.
If we're matching the exact error message then its best to define this a constant in pkg/tlsutil so we can reuse it here. Instead of defining it twice.
|
LGTM after nits |
|
merging when CI turns green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test TLS Util for the case where only the application TLS asset exists in cluster and its corresponding CA doesn't. In this situation, the CertGenerator can't proceed because it can't generate a new CA as the new CA can't be used to verify the existing application TLS asset. Therefore, CertGenerator returns an error to the caller.
cc/ @hasbro17