pkg/tlsutil: impl none of the CA and App TLS assets are found #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanminshi
changed the title
hasbro17
reviewed
Aug 31, 2018
test/e2e/tls_util_test.go
Outdated
| } | ||
|
|
||
| // use Pod as a dummy runtime object for the CR input of GenerateCert(). | ||
| func toDummyCR(namespace string) runtime.Object { |
There was a problem hiding this comment.
Rename this to newDummyCR() since we're not really converting anything to use toDummyCR().
Also change the comment format to be Go style: newDummyCR returns a dummy runtime object ....
There was a problem hiding this comment.
yeah, that's right.
hasbro17
reviewed
Aug 31, 2018
test/e2e/tls_util_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func toAppSvc(namespace string) *v1.Service { |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement and test the case where none of the CA and application TLS assets are found. In this case, GenerateCert should simply generate both and put them into the k8s cluster.