cleanup command has additional flags to handle deletion of CRDs #4619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashmigottipati
force-pushed
the
cleanup-flags
branch
from
f4a6d17 to
7a7f1e1
Compare
rashmigottipati
force-pushed
the
cleanup-flags
branch
from
7a7f1e1 to
7bef309
Compare
estroz
suggested changes
Mar 10, 2021
rashmigottipati
force-pushed
the
cleanup-flags
branch
from
7bef309 to
5148635
Compare
rashmigottipati
force-pushed
the
cleanup-flags
branch
2 times, most recently
from
2d92aad to
8149209
Compare
… crds Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>
Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>
Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>
Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>
Signed-off-by: rashmigottipati <chowdary.grashmi@gmail.com>
rashmigottipati
force-pushed
the
cleanup-flags
branch
from
8149209 to
f3b7325
Compare
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
operator-sdk cleanup command has optional additional flags (
--delete-alland--delete-crds) to handle deletion of CRDs.To preserve the current behavior, both these flags will be set to true by default.
If a user intends to not cleanup CRDs, then the user will have to set the flags as below:
operator-sdk cleanup <operatorPackageName> --delete-all=false --delete-crds=falseto prevent deletion of CRDsMotivation for the change:
The existing operator-sdk cleanup command currently deletes the CRDs and all other resources owned by the operator, without an option to disable this behavior. Ideally, the cleanup command should have certain flags that prevent deletion of CRDs, for feature parity with the kubectl operator plugin and also so that eventually SDK can opt-in and use OLM's operand cleanup feature.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docsSigned-off-by: rashmigottipati chowdary.grashmi@gmail.com