Skip to content

Conversation

estroz
Copy link
Member

@estroz estroz commented Mar 9, 2021

Description of the change:

  • internal/testutils: rewrite UncommentCode() to only append newlines if line is not the last in target

Motivation for the change: unnecessary newlines.

Signed-off-by: Eric Stroczynski ericstroczynski@gmail.com

Checklist

If the pull request includes user-facing changes, extra documentation is required:

…f line is not the last in target

Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
@estroz estroz temporarily deployed to deploy March 9, 2021 20:17 Inactive
@estroz estroz temporarily deployed to deploy March 9, 2021 20:17 Inactive
@estroz estroz temporarily deployed to deploy March 9, 2021 20:17 Inactive
@estroz estroz temporarily deployed to deploy March 9, 2021 20:17 Inactive
@estroz estroz temporarily deployed to deploy March 9, 2021 20:17 Inactive
@estroz estroz temporarily deployed to deploy March 9, 2021 20:17 Inactive
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 9, 2021
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@estroz estroz merged commit a07364f into operator-framework:master Mar 9, 2021
@estroz estroz deleted the chore/fix-testdata-newlines branch March 9, 2021 20:43
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Mar 11, 2021
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Mar 11, 2021
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants