Run generate before prerelease #4952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianvf
force-pushed
the
generate-prerelease
branch
from
99f603d to
0ed43e0
Compare
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
fabianvf
force-pushed
the
generate-prerelease
branch
from
0ed43e0 to
ac911e7
Compare
jmrodri
requested changes
Jun 10, 2021
|
|
||
| ```sh | ||
| git add --all | ||
| git add Makefile changelog website testdata |
|
|
||
| ```sh | ||
| git add --all | ||
| git add Makefile changelog website testdata |
|
Fixing typo will allow me to approve this. |
Co-authored-by: Jesus Rodriguez <jmrodri@gmail.com> Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
fabianvf
force-pushed
the
generate-prerelease
branch
from
57e9e7a to
86a008a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
make generateis now run beforemake prerelease, and the documentation is updated to match.Motivation for the change:
This is a necessary step in the release process.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs