Skip to content

Conversation

laxmikantbpandhare
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare commented Jun 15, 2021

Description of the change:

This fix is for the issue #4980.

Motivation for the change:

Throw appropriate error if API endpoint has path in it.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci openshift-ci bot requested review from estroz and rashmigottipati June 15, 2021 19:21
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 16, 2021

New changes are detected. LGTM label has been removed.

@fabianvf fabianvf merged commit b2380b5 into operator-framework:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix for Development proxy ignores path in K8s API URL. Throw error if it has path.
3 participants