Skip to content

Conversation

laxmikantbpandhare
Copy link
Member

Description of the change:
generator command got deprecated in 1.21+ version of kubectl

Motivation for the change:
Update the kubectl version

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@laxmikantbpandhare laxmikantbpandhare linked an issue Oct 8, 2021 that may be closed by this pull request
@laxmikantbpandhare laxmikantbpandhare added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2021
@laxmikantbpandhare laxmikantbpandhare self-assigned this Oct 8, 2021
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment no longer makes sense, please remove it or add a comment that better describes .

@jmrodri
Copy link
Member

jmrodri commented Oct 9, 2021

@laxmikantbpandhare also you need make sure you run the tests locally because there is something that isn't quite right.

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
…ated webhook and it was failing

Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
@laxmikantbpandhare
Copy link
Member Author

@laxmikantbpandhare also you need make sure you run the tests locally because there is something that isn't quite right.

Thank you for helping out. The issue was we updated ENVTEST_K8S_VERSION version to 1.22.1 and in this latest version webhook is deprecated, check here.

@laxmikantbpandhare laxmikantbpandhare removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2021
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2021
@laxmikantbpandhare laxmikantbpandhare merged commit 7685cb1 into operator-framework:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump envtest binaries to k8s 1.21

2 participants