-
Notifications
You must be signed in to change notification settings - Fork 1.8k
removed generator flag as it is deprecated in recent version of kubectl 1.21+ #5295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed generator flag as it is deprecated in recent version of kubectl 1.21+ #5295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment no longer makes sense, please remove it or add a comment that better describes .
@laxmikantbpandhare also you need make sure you run the tests locally because there is something that isn't quite right. |
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
…ated webhook and it was failing Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Signed-off-by: laxmikantbpandhare <laxmikantpandhare@gmail.com>
Thank you for helping out. The issue was we updated ENVTEST_K8S_VERSION version to 1.22.1 and in this latest version webhook is deprecated, check here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description of the change:
generator command got deprecated in 1.21+ version of kubectl
Motivation for the change:
Update the kubectl version
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs