Skip to content

deprecation:Optional(stage: alpha) Community Operator bundle validator #5414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2021
Merged

deprecation:Optional(stage: alpha) Community Operator bundle validator #5414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions changelog/fragments/deprecation.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# entries is a list of entries to include in
# release notes and/or the migration guide
entries:
- description: >
Deprecation of the Optional(stage: alpha) Community Operator bundle validation. Its checks were moved to the [external validator](https://github.com/redhat-openshift-ecosystem/ocp-olm-catalog-validator/).

# kind is one of:
# - addition
# - change
# - deprecation
# - removal
# - bugfix
kind: "deprecation"

# Is this a breaking change?
breaking: false
8 changes: 7 additions & 1 deletion internal/cmd/operator-sdk/bundle/validate/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ This validator allows check the bundle against an specific Kubernetes cluster ve

$ operator-sdk bundle validate ./bundle --select-optional name=operatorhub --optional-values=k8s-version=1.22

To validate a bundle against the (alpha) validator for Community Operators specifically, in addition to required bundle validators:
[Deprecated] To validate a bundle against the (alpha) validator for Community Operators specifically, in addition to required bundle validators:

$ operator-sdk bundle validate ./bundle --select-optional name=community --optional-values=index-path=bundle.Dockerfile

Expand Down Expand Up @@ -125,6 +125,12 @@ func NewCmd() *cobra.Command {
return nil
}

if c.selectorRaw == "name=community" {
logger.Warnf("The Optional(stage: alpha) Community Operator bundle validator is deprecated and" +
" will be removed in a future release. You can do these checks using the external validator: " +
"https://github.com/redhat-openshift-ecosystem/ocp-olm-catalog-validator/")
}

result, err := c.run(logger, args[0])
if err != nil {
logger.Fatal(err)
Expand Down
2 changes: 1 addition & 1 deletion website/content/en/docs/cli/operator-sdk_bundle_validate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ This validator allows check the bundle against an specific Kubernetes cluster ve

$ operator-sdk bundle validate ./bundle --select-optional name=operatorhub --optional-values=k8s-version=1.22

To validate a bundle against the (alpha) validator for Community Operators specifically, in addition to required bundle validators:
[Deprecated] To validate a bundle against the (alpha) validator for Community Operators specifically, in addition to required bundle validators:

$ operator-sdk bundle validate ./bundle --select-optional name=community --optional-values=index-path=bundle.Dockerfile

Expand Down