Skip to content

Conversation

sebgoa
Copy link
Contributor

@sebgoa sebgoa commented Oct 10, 2018

otherwise operator-sdk up local fails.

otherwise `operator-sdk up local` fails.
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 10, 2018
@openshift-ci-robot
Copy link

Hi @sebgoa. Thanks for your PR.

I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shawn-hurley
Copy link
Member

LGTM

@hasbro17
Copy link
Contributor

It won't technically fail but print out an error as is reported in #462

$ operator-sdk up local
INFO[0000] Go Version: go1.10.2
INFO[0000] Go OS/Arch: darwin/amd64
INFO[0000] operator-sdk Version: 0.0.6+git
ERRO[0000] failed to initialize service object for operator metrics: OPERATOR_NAME must be set
INFO[0000] Watching app.example.com/v1alpha1, AppService, default, 5000000000

But this should help suppress that error.
LGTM

@lilic We should move OPERATOR_NAME inside up local like you've suggested before
#462 (comment)

@hasbro17 hasbro17 merged commit 0057336 into operator-framework:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants