Add testing for the sample memcached-operator metric #6025
Conversation
|
/hold |
assafad
force-pushed
the
metrics-test
branch
from
4709bb6 to
611736f
Compare
openshift-ci
bot
added
the
do-not-merge/hold
assafad
force-pushed
the
metrics-test
branch
from
611736f to
be2b6c1
Compare
assafad
changed the title
assafad
force-pushed
the
metrics-test
branch
from
be2b6c1 to
e3a1ac8
Compare
|
/retest |
|
@assafad: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: assaf-admi <aadmi@redhat.com>
|
/retest |
|
@assafad: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@assafad: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@everettraven Thank you for reviewing this PR. Anything else we miss in order to get it merged? |
4 participants
Signed-off-by: assafad aadmi@redhat.com
Description of the change:
This PR adds a test for the sample memcached-operator. The test validates that the new operator metric
memcached_deployment_size_undesired_count_totalexists and works as expected.Motivation for the change:
We would like to implement observability concepts for the memcahced-operator, in order to have the operator in Deep Insights capability level. Then, we may use it as a reference in an observability best-practices tutorial in Operator-SDK documentation.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs