Skip to content

Conversation

everettraven
Copy link
Contributor

@everettraven everettraven commented Oct 4, 2022

Description of the change:

  • Updates the documentation for generating manifests

Motivation for the change:

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven everettraven changed the title Docs/manifests (docs): Update documentation for generating manifests Oct 4, 2022
@everettraven everettraven changed the title (docs): Update documentation for generating manifests Update documentation for generating manifests Oct 4, 2022
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@jberkhahn
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2022
Copy link
Contributor

@michaelryanpeter michaelryanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@everettraven I left a couple of small suggestions. Please let me know if you have questions!

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2022
Copy link
Contributor

@michaelryanpeter michaelryanpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for docs.

If there are technical changes that require rewording/revision, I am happy to give it another look.

Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2022
@everettraven everettraven merged commit 1e1a6b1 into operator-framework:master Oct 18, 2022
@everettraven everettraven deleted the docs/manifests branch October 18, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generating Manifests and Metadata page --kustomize flag not available
5 participants