Constants refactor #648
Closed
Constants refactor #648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
requested review from
AlexNPavel,
hasbro17,
joelanford,
lilic,
mhrivnak,
shawn-hurley and
spahl
openshift-ci-robot
added
the
size/L
openshift-ci-robot
added
the
do-not-merge/work-in-progress
estroz
force-pushed
the
constants-refactor
branch
from
6d1dea6 to
e0dfeda
Compare
Merged
estroz
force-pushed
the
constants-refactor
branch
from
e0dfeda to
8649226
Compare
estroz
force-pushed
the
constants-refactor
branch
from
8649226 to
73b64c2
Compare
…onstants instead of hard-coded strings for dirs and filenames
estroz
force-pushed
the
constants-refactor
branch
from
73b64c2 to
09d91f8
Compare
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
Closing, as #649 is being merged directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
scaffold-specific file names were moved frompkg/scaffold/constants.goto scaffold files that use them. Both file and directory constants were exported, and are now used incommands/operator-sdk/cmdinstead of hard-coded strings.Motivation for the change: we want to prevent data drift on changes to the SDK's structure, and solidify naming conventions so files and directories can be used properly as arguments. Moving file names to their respective scaffold files agrees with the idea that utility packages and files containing disparate data are best avoided.