-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
www/caddy: Add Caddy widgets for 24.7 new dashboard #4049
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us in the new Dashboard.
…or the automatic certificates. Swings magic wand ~asyncio.
…ng the new diagnostics certificate API.
… resize since the list can be long.
…ip turns yellow when 14 days are left. The remaining days are shown in the overview next to the date.
…ta, to only update the UI if changes are detected in the data.
swhite2
reviewed
Jun 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I like the usage of asyncio here, since openssl doesn't support parsing multiple paths concurrently.. Perhaps @AdSchellevis might have an opinion on this as well.
www/caddy/src/opnsense/scripts/OPNsense/Caddy/caddy_diagnostics.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for discussion with @swhite2
Coming from the perspective of plugins, the widgets could be pluggable like this. What's left to solve is the translations, so this is like a proof of concept and has to be adjusted.
Screenshot (some domain details have been omitted with text editing):
What this adds:
Since this is a WIP and POC it still needs some cleanup that will be done over time.