Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5017 : Updated example screenshots in wiki as per new oppia-android ui #5107

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

MohitGupta121
Copy link
Member

@MohitGupta121 MohitGupta121 commented Jul 27, 2023

Explanation

Fix #5017 : Updated example screenshots in wiki as per new oppia-android ui

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adhiamboperes PTAL, Thanks!
Please suggest anything if need to change or not clear.

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohitGupta121, this LGTM

@oppiabot
Copy link

oppiabot bot commented Jul 28, 2023

Unassigning @adhiamboperes since they have already approved the PR.

@oppiabot
Copy link

oppiabot bot commented Jul 28, 2023

Assigning @seanlip for code owner reviews. Thanks!

@seanlip
Copy link
Member

seanlip commented Jul 28, 2023

This looks fine, I'm merging it. Thanks @MohitGupta121!

@seanlip seanlip merged commit faf148b into develop Jul 28, 2023
25 checks passed
@seanlip seanlip deleted the new_guide_screenshots branch July 28, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update example screenshots in "Overview of the Oppia Android codebase and architecture" wiki
3 participants