-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4539: Replace CaseSensitiveEquals by Equals in dev assets #5154
Fixes #4539: Replace CaseSensitiveEquals by Equals in dev assets #5154
Conversation
Checking out the latest code in 'develop'
Update repository
I tested this by running the app from both gradle and bazel; then doing the "Order is Important" chapter from the story "Ratios: Part 1". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @masclot.
Since we don't have automated tests for these assets, what you can do is add before/after videos and screenshots. If you check out this branch, a video recording should show that the bug does not occur, and a logcat screenshot should show the stacktrace is not logged. Similarly, if you check out develop, the original bug and error log should be seen in the video and screenshot. Please add these to your PR description and reassign once done.
Done. PTAL @adhiamboperes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @masclot!
Unassigning @adhiamboperes since they have already approved the PR. |
Assigning @BenHenning for code owner reviews. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @masclot! This LGTM.
Restarting failing CI (since it appears to be an infrastructure flake) and enabling auto-merge. |
Unassigning @BenHenning since they have already approved the PR. |
Hi @masclot, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks! |
Explanation
Fixes #4539: Replace the rule type CaseSensitiveEquals by Equals in dev assets. This only affects the topics used in dev environment. The rule type CaseSensitiveEquals is no longer supported.
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then:
Videos
Screenshots