Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4539: Replace CaseSensitiveEquals by Equals in dev assets #5154

Merged

Conversation

masclot
Copy link
Collaborator

@masclot masclot commented Sep 19, 2023

Explanation

Fixes #4539: Replace the rule type CaseSensitiveEquals by Equals in dev assets. This only affects the topics used in dev environment. The rule type CaseSensitiveEquals is no longer supported.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Videos

current new
fix_for_CaseSensitiveEquals_current.webm fix_for_CaseSensitiveEquals_new.webm

Screenshots

current new
Screenshot fix_for_CaseSensitiveEquals_current Screenshot fix_for_CaseSensitiveEquals_new

@masclot masclot requested a review from a team as a code owner September 19, 2023 14:53
@masclot
Copy link
Collaborator Author

masclot commented Sep 19, 2023

I tested this by running the app from both gradle and bazel; then doing the "Order is Important" chapter from the story "Ratios: Part 1".

@adhiamboperes adhiamboperes self-assigned this Sep 20, 2023
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @masclot.

Since we don't have automated tests for these assets, what you can do is add before/after videos and screenshots. If you check out this branch, a video recording should show that the bug does not occur, and a logcat screenshot should show the stacktrace is not logged. Similarly, if you check out develop, the original bug and error log should be seen in the video and screenshot. Please add these to your PR description and reassign once done.

@masclot
Copy link
Collaborator Author

masclot commented Sep 26, 2023

Thanks @masclot.

Since we don't have automated tests for these assets, what you can do is add before/after videos and screenshots. If you check out this branch, a video recording should show that the bug does not occur, and a logcat screenshot should show the stacktrace is not logged. Similarly, if you check out develop, the original bug and error log should be seen in the video and screenshot. Please add these to your PR description and reassign once done.

Done. PTAL @adhiamboperes

@masclot masclot assigned adhiamboperes and unassigned masclot Sep 26, 2023
Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @masclot!

@oppiabot
Copy link

oppiabot bot commented Sep 26, 2023

Unassigning @adhiamboperes since they have already approved the PR.

@oppiabot
Copy link

oppiabot bot commented Sep 26, 2023

Assigning @BenHenning for code owner reviews. Thanks!

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @masclot! This LGTM.

@BenHenning
Copy link
Member

BenHenning commented Sep 28, 2023

Restarting failing CI (since it appears to be an infrastructure flake) and enabling auto-merge.

@BenHenning BenHenning enabled auto-merge (squash) September 28, 2023 00:41
@oppiabot
Copy link

oppiabot bot commented Sep 28, 2023

Unassigning @BenHenning since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Sep 28, 2023
@oppiabot
Copy link

oppiabot bot commented Sep 28, 2023

Hi @masclot, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

@BenHenning BenHenning merged commit 42ee1bd into oppia:develop Sep 28, 2023
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submit button is not enabled after inputting the answer
3 participants