-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #5344: Update models to support classrooms #5418
Conversation
… classroom. IDs of Science & Maths classrooms is interchanged to make the relative ordering of the topics same as previous. This is required by several UI tests to pass.
@adhiamboperes PTAL. I have updated the classroom data files with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17!
I left a few comments inline, PTAL.
domain/src/main/java/org/oppia/android/domain/topic/TopicListController.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/topic/TopicListController.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/topic/TopicListController.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/topic/TopicListController.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/topic/TopicListController.kt
Outdated
Show resolved
Hide resolved
Thanks for the review @BenHenning! I have addressed the comments, PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17! Took a full pass and had just a few comments--PTAL.
domain/src/main/java/org/oppia/android/domain/topic/TopicController.kt
Outdated
Show resolved
Hide resolved
domain/src/main/java/org/oppia/android/domain/topic/TopicController.kt
Outdated
Show resolved
Hide resolved
@BenHenning PTAL. |
Merged the Kotlin and Bazel update changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @theMr17! The latest changes LGTM--no concerns here. I also find the latest code a lot cleaner, so I think the most recent changes have simplified things.
@adhiamboperes / @theMr17 please go ahead and merge once you're ready (I didn't want to in case it broke any downstream chaining). |
Hi @theMr17, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 12 KiB (Added) APK download size (estimated): 14 MiB (old), 14 MiB (new), 15 KiB (Added) Method count: 221791 (old), 222270 (new), 479 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6550 (old), 6550 (new), 0 (No change)
Lesson assets: 105 (old), 111 (new), 6 (Added):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 15 MiB (old), 15 MiB (new), 12 KiB (Added) Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 102 KiB (old), 102 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 0 bytes (No change) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 3812 bytes (Added) APK download size (estimated): 9150 KiB (old), 9152 KiB (new), 2084 bytes (Added) Method count: 99436 (old), 99462 (new), 26 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 111 (new), 6 (Added):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 3812 bytes (Added) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 9 MiB (old), 9 MiB (new), 3880 bytes (Added) APK download size (estimated): 9135 KiB (old), 9139 KiB (new), 3209 bytes (Added) Method count: 99436 (old), 99462 (new), 26 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 111 (new), 6 (Added):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 3876 bytes (Added) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 9 MiB (old), 9 MiB (new), 3788 bytes (Added) APK download size (estimated): 9136 KiB (old), 9137 KiB (new), 1828 bytes (Added) Method count: 99436 (old), 99462 (new), 26 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 111 (new), 6 (Added):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 3788 bytes (Added) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 12 KiB (Added) APK download size (estimated): 14 MiB (old), 14 MiB (new), 15 KiB (Added) Method count: 221791 (old), 222270 (new), 479 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6550 (old), 6550 (new), 0 (No change)
Lesson assets: 105 (old), 111 (new), 6 (Added):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 15 MiB (old), 15 MiB (new), 12 KiB (Added) Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 102 KiB (old), 102 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 0 bytes (No change) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 3816 bytes (Added) APK download size (estimated): 9150 KiB (old), 9152 KiB (new), 2083 bytes (Added) Method count: 99436 (old), 99462 (new), 26 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 111 (new), 6 (Added):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 3816 bytes (Added) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 4 bytes (Removed) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 9 MiB (old), 9 MiB (new), 3884 bytes (Added) APK download size (estimated): 9135 KiB (old), 9139 KiB (new), 3207 bytes (Added) Method count: 99436 (old), 99462 (new), 26 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 111 (new), 6 (Added):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 3884 bytes (Added) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 4 bytes (Removed) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 9 MiB (old), 9 MiB (new), 3788 bytes (Added) APK download size (estimated): 9136 KiB (old), 9137 KiB (new), 1828 bytes (Added) Method count: 99436 (old), 99462 (new), 26 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 111 (new), 6 (Added):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 3792 bytes (Added) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 4 bytes (Removed) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) |
1 similar comment
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 12 KiB (Added) APK download size (estimated): 14 MiB (old), 14 MiB (new), 15 KiB (Added) Method count: 221791 (old), 222270 (new), 479 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6550 (old), 6550 (new), 0 (No change)
Lesson assets: 105 (old), 111 (new), 6 (Added):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 15 MiB (old), 15 MiB (new), 12 KiB (Added) Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 102 KiB (old), 102 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 0 bytes (No change) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 3816 bytes (Added) APK download size (estimated): 9150 KiB (old), 9152 KiB (new), 2083 bytes (Added) Method count: 99436 (old), 99462 (new), 26 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 111 (new), 6 (Added):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 3816 bytes (Added) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 4 bytes (Removed) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 9 MiB (old), 9 MiB (new), 3884 bytes (Added) APK download size (estimated): 9135 KiB (old), 9139 KiB (new), 3207 bytes (Added) Method count: 99436 (old), 99462 (new), 26 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 111 (new), 6 (Added):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 3884 bytes (Added) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 4 bytes (Removed) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 9 MiB (old), 9 MiB (new), 3788 bytes (Added) APK download size (estimated): 9136 KiB (old), 9137 KiB (new), 1828 bytes (Added) Method count: 99436 (old), 99462 (new), 26 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 111 (new), 6 (Added):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 3792 bytes (Added) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 4 bytes (Removed) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 4 bytes (Removed) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 4 bytes (Removed) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 4 bytes (Removed) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 4 bytes (Removed) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 16 MiB (old), 16 MiB (new), 12 KiB (Added) APK download size (estimated): 14 MiB (old), 14 MiB (new), 15 KiB (Added) Method count: 221791 (old), 222270 (new), 479 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6550 (old), 6550 (new), 0 (No change)
Lesson assets: 105 (old), 111 (new), 6 (Added):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 15 MiB (old), 15 MiB (new), 12 KiB (Added) Configuration hdpiAPK file size: 59 KiB (old), 59 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 53 KiB (old), 53 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 102 KiB (old), 102 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 67 KiB (old), 67 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 76 KiB (old), 76 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 79 KiB (old), 79 KiB (new), 0 bytes (No change) AlphaExpand to see flavor specificsUniversal APKAPK file size: 10 MiB (old), 10 MiB (new), 3820 bytes (Added) APK download size (estimated): 9150 KiB (old), 9152 KiB (new), 2083 bytes (Added) Method count: 99436 (old), 99462 (new), 26 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 111 (new), 6 (Added):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 3820 bytes (Added) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 9 MiB (old), 9 MiB (new), 3884 bytes (Added) APK download size (estimated): 9135 KiB (old), 9139 KiB (new), 3155 bytes (Added) Method count: 99436 (old), 99462 (new), 26 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 111 (new), 6 (Added):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 3888 bytes (Added) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 9 MiB (old), 9 MiB (new), 3792 bytes (Added) APK download size (estimated): 9136 KiB (old), 9137 KiB (new), 1835 bytes (Added) Method count: 99436 (old), 99462 (new), 26 (Added) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5504 (old), 5504 (new), 0 (No change)
Lesson assets: 105 (old), 111 (new), 6 (Added):
AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 9 MiB (old), 9 MiB (new), 3796 bytes (Added) Configuration hdpiAPK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 52 KiB (old), 52 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 46 KiB (old), 46 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 90 KiB (old), 90 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 60 KiB (old), 60 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 69 KiB (old), 69 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 71 KiB (old), 71 KiB (new), 0 bytes (No change) |
Explanation
Fixes part of #5344
ClassroomIdList
,ClassroomSummary
, &EphemeralClassroomSummary
and updatesClassroomList
to contain a list ofEphemeralClassroomSummary
s and awritten_translation_context
.classroomId
&classroomTitle
.Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: