-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Part of #10474: Enables strict typescript checks for some files- (5) #13111
Conversation
some title
merged-with-develop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
let data = this.assetsCache.get(filename); | ||
if (this.isCached(filename) && data !== undefined) { | ||
return new AudioFile(filename, data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DubeySandeep PTAL
@DubeySandeep Thanks for the review, I have addressed your comments PTAL thanks! |
@kevintab95 @DubeySandeep PTAL |
Hi @mridul-netizen, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for codeowner files. Thanks @mridul-netizen!
Unassigning @kevintab95 since they have already approved the PR. |
@DubeySandeep PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the codeowner file
Unassigning @DubeySandeep since they have already approved the PR. |
Hi @mridul-netizen, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks! |
Overview
Essential Checklist
Proof that changes are correct
PR Pointers
Files Covered
PasteBin to Errors - link