Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Part of #10474: Enables strict typescript checks for some files- (5) #13111

Merged
merged 59 commits into from
Jun 30, 2021

Conversation

mridul-netizen
Copy link
Contributor

Overview

  1. This PR fixes or fixes part of Make typescript checks strict #10474 .
  2. This PR does the following: [Make Typescript checks strict for some files]

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

image

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Oppiabot can assign anyone for review/help if you leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL"
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

Files Covered

   "core/templates/domain/utilities/image-file.model.ts",
    "core/templates/services/assets-backend-api.service.ts",
    "core/templates/services/assets-backend-api.service.spec.ts",
    "core/templates/components/summary-tile/story-summary-tile.component.ts",
    "extensions/objects/templates/image-with-regions-reset-confirmation.component.ts",
    "extensions/objects/templates/image-with-regions-reset-confirmation.component.spec.ts",
    "extensions/objects/templates/graph-editor.component.ts",
    "core/templates/pages/exploration-player-page/switch-content-language-refresh-required-modal.component.ts",
    "core/templates/pages/exploration-player-page/switch-content-language-refresh-required-modal.component.spec.ts",
    "core/templates/pages/interaction-specs.constants.ajs.ts",
    "core/templates/domain/exploration/ParamSpecObjectFactory.ts",
    "core/templates/domain/exploration/ParamSpecObjectFactorySpec.ts",
    "extensions/classifiers/svm-prediction.service.ts",
    "extensions/classifiers/svm-prediction.service.spec.ts",
    "core/templates/domain/feedback_message/ThreadMessage.model.ts",
    "core/templates/domain/feedback_message/ThreadMessage.model.spec.ts",
    "core/templates/services/contextual/window-dimensions.service.ts",
    "core/templates/services/contextual/window-dimensions.service.spec.ts",
    "core/templates/pages/exploration-editor-page/editor-tab/templates/modal-templates/delete-state-skill-modal.component.ts",
    "core/templates/pages/exploration-editor-page/editor-tab/templates/modal-templates/delete-state-skill-modal.component.spec.ts",
    "core/templates/filters/string-utility-filters/truncate.pipe.ts",
    "core/templates/filters/string-utility-filters/truncate.pipe.spec.ts",
    "core/templates/domain/question/question-summary-for-one-skill-object.model.ts",
    "core/templates/domain/question/question-summary-for-one-skill-object.model.spec.ts",
    "core/templates/domain/skill/skill-mastery-backend-api.service.ts",
    "core/templates/domain/skill/skill-mastery-backend-api.service.spec.ts",
    "core/templates/domain/exploration/recorded-voiceovers.model.ts",
    "core/templates/domain/exploration/recorded-voiceovers.model.spec.ts",
    "core/templates/filters/format-rte-preview.pipe.ts",
    "core/templates/filters/format-rte-preview.pipe.spec.ts",
    "extensions/interactions/customization-args-defs.ts",
    "extensions/interactions/rule-input-defs.ts",
    "core/templates/components/code-mirror/codemirror.module.ts",

PasteBin to Errors - link

Copy link
Contributor

@iamprayush iamprayush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iamprayush iamprayush removed their assignment Jun 25, 2021
Comment on lines +77 to +79
let data = this.assetsCache.get(filename);
if (this.isCached(filename) && data !== undefined) {
return new AudioFile(filename, data);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mridul-netizen
Copy link
Contributor Author

@DubeySandeep Thanks for the review, I have addressed your comments PTAL thanks!

@mridul-netizen
Copy link
Contributor Author

@kevintab95 @DubeySandeep PTAL

@oppiabot oppiabot bot added the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Jun 27, 2021
@oppiabot
Copy link

oppiabot bot commented Jun 27, 2021

Hi @mridul-netizen, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

@DubeySandeep DubeySandeep removed their assignment Jun 28, 2021
@oppiabot oppiabot bot removed the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Jun 28, 2021
Copy link
Member

@kevintab95 kevintab95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for codeowner files. Thanks @mridul-netizen!

@oppiabot
Copy link

oppiabot bot commented Jun 28, 2021

Unassigning @kevintab95 since they have already approved the PR.

@mridul-netizen
Copy link
Contributor Author

@DubeySandeep PTAL

Copy link
Member

@DubeySandeep DubeySandeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the codeowner file

@oppiabot
Copy link

oppiabot bot commented Jun 30, 2021

Unassigning @DubeySandeep since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Jun 30, 2021
@oppiabot
Copy link

oppiabot bot commented Jun 30, 2021

Hi @mridul-netizen, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to merge this PR once the CI checks pass and you're happy with it. Thanks!

@mridul-netizen mridul-netizen merged commit be70794 into oppia:develop Jun 30, 2021
@mridul-netizen mridul-netizen deleted the st-5 branch June 30, 2021 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants