Adds schema for handlers admin, classifier, & classroom modules #13223

Nik-09 · 2021-06-26T16:14:35Z

Overview

Schema for handler classes in admin.py, classifier.py and classroom.py

Essential Checklist

The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
The linter/Karma presubmit checks have passed locally on your machine.
"Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
- This lets reviewers restart your CircleCI tests for you.
The PR is made from a branch that's not called "develop".

Proof that changes are correct

admin.mp4

PR Pointers

Make sure to follow the instructions for making a code change.
Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
For what code owners will expect, see the Code Owner's wiki page.
Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
Never force push. If you do, your PR will be closed.
Oppiabot can assign anyone for review/help if you leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL"
Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

…hitecture

…to SVS_architecture

…hitecture

rohitkatlaa

Other than creating an issue regarding the clear_search_index, everything else LGTM! Thanks!

rohitkatlaa · 2021-07-07T06:06:34Z

core/controllers/admin.py

+                        'update_feature_flag_rules'
+                    ]
+                },
+                'default_value': None


@Nik-09 Please do create an issue because the error doesn't seem to be trivial and further analysis might be required.

core/controllers/admin.py

Nik-09

@rohitkatlaa PTAL. Thank you

Nik-09 · 2021-07-07T11:27:53Z

core/controllers/admin.py

+                        'update_feature_flag_rules'
+                    ]
+                },
+                'default_value': None


Nik-09 · 2021-07-07T12:49:18Z

@DubeySandeep Pleae take a look, Thank you.

rohitkatlaa

LGTM! Thanks @Nik-09 !

oppiabot · 2021-07-07T13:19:29Z

Unassigning @rohitkatlaa since they have already approved the PR.

oppiabot · 2021-07-07T15:51:31Z

Hi @Nik-09. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

oppiabot · 2021-07-07T16:57:44Z

Unassigning @DubeySandeep since they have already approved the PR.

oppiabot · 2021-07-07T22:41:22Z

Hi @Nik-09, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

…for_handlers_M12

Nik-09 added 30 commits June 8, 2021 08:42

payload_validator(created) + schema_utils(modified) for SVS architecture

d5f62b6

payload

63b59db

validate_args_schema in base + backend tests

09698da

resolves merge conflicts

6184962

Adds linters to verify handlers must have schema

7a0c0da

Merge branch 'develop' of https://github.com/oppia/oppia into SVS_arc…

ccfc515

…hitecture

Shows exception message in frontend when SVS validation fails.

d6d6782

adds schema in backend test

923afbf

fix coverage

7ff6796

adds backend test for payload_validator into shard 1.

4775353

Changes logic for handling default_value cases.

87b8a8a

removes dict from properties list in schema utils

21c2909

fix coverage

9396931

changes codeowners

dc49efd

Adds backend unit tests + comments + docstrings

9672271

fix coverage

1e023cd

Merge branch 'SVS_architecture' of https://github.com/Nik-09/oppia in…

be3b7e8

…to SVS_architecture

adds backend tests for coverage

2514c36

Merge branch 'develop' of https://github.com/oppia/oppia into SVS_arc…

9f521fa

…hitecture

fix coverage

822d2d7

adds backend tests for coverage

b5c087a

fix coverage

8ef20d4

fix coverage

0caee8b

Merge branch 'develop' of https://github.com/oppia/oppia into SVS_arc…

6507fd4

…hitecture

adds test into shard

b5041d9

backend coverage

2a979a8

fix coverage

dda9fce

structured backend test.

7ead84c

adds docstring

5eca27e

fix coverage

6e22684

oppiabot bot assigned Nik-09 Jul 7, 2021

Nik-09 added 2 commits July 7, 2021 07:52

fixes merge conflict

abe658f

fixes backend test.

e7798ef

oppiabot bot removed the PR: don't merge - HAS MERGE CONFLICTS label Jul 7, 2021

rohitkatlaa approved these changes Jul 7, 2021

View reviewed changes

rohitkatlaa removed their assignment Jul 7, 2021

adds todo comment.

28b72b5

rohitkatlaa suggested changes Jul 7, 2021

View reviewed changes

core/controllers/admin.py Outdated Show resolved Hide resolved

Nik-09 added 2 commits July 7, 2021 17:15

uses constant istant of hard coding.

8457b21

updates comment.

28413b8

Nik-09 commented Jul 7, 2021

View reviewed changes

core/controllers/admin.py

'update_feature_flag_rules'

]

},

'default_value': None

Copy link

Member Author

Nik-09 Jul 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Nik-09 requested a review from rohitkatlaa July 7, 2021 12:48

Nik-09 assigned rohitkatlaa and unassigned Nik-09 Jul 7, 2021

rohitkatlaa approved these changes Jul 7, 2021

View reviewed changes

oppiabot bot unassigned rohitkatlaa Jul 7, 2021

oppiabot bot added the PR: don't merge - HAS MERGE CONFLICTS label Jul 7, 2021

oppiabot bot assigned Nik-09 Jul 7, 2021

fixes merge conflict.

db75b03

oppiabot bot removed the PR: don't merge - HAS MERGE CONFLICTS label Jul 7, 2021

DubeySandeep approved these changes Jul 7, 2021

View reviewed changes

oppiabot bot unassigned DubeySandeep Jul 7, 2021

Merge branch 'develop' of https://github.com/oppia/oppia into schema_…

23e6082

…for_handlers_M12

rohitkatlaa merged commit a2f97b5 into oppia:develop Jul 8, 2021

Nik-09 mentioned this pull request Jul 30, 2021

Write schemas for handler class arguments #13162

Open

99 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds schema for handlers admin, classifier, & classroom modules #13223

Adds schema for handlers admin, classifier, & classroom modules #13223

Nik-09 commented Jun 26, 2021 •

edited

Loading

rohitkatlaa left a comment

rohitkatlaa Jul 7, 2021

Nik-09 left a comment

Nik-09 Jul 7, 2021

Nik-09 commented Jul 7, 2021

rohitkatlaa left a comment

oppiabot bot commented Jul 7, 2021

oppiabot bot commented Jul 7, 2021

oppiabot bot commented Jul 7, 2021

oppiabot bot commented Jul 7, 2021

Adds schema for handlers admin, classifier, & classroom modules #13223

Adds schema for handlers admin, classifier, & classroom modules #13223

Conversation

Nik-09 commented Jun 26, 2021 • edited Loading

Overview

Essential Checklist

Proof that changes are correct

PR Pointers

rohitkatlaa left a comment

Choose a reason for hiding this comment

rohitkatlaa Jul 7, 2021

Choose a reason for hiding this comment

Nik-09 left a comment

Choose a reason for hiding this comment

Nik-09 Jul 7, 2021

Choose a reason for hiding this comment

Nik-09 commented Jul 7, 2021

rohitkatlaa left a comment

Choose a reason for hiding this comment

oppiabot bot commented Jul 7, 2021

oppiabot bot commented Jul 7, 2021

oppiabot bot commented Jul 7, 2021

oppiabot bot commented Jul 7, 2021

Nik-09 commented Jun 26, 2021 •

edited

Loading