Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 2.3 (Improve line and branch coverage for the frontend and the backend): Increased coverage in some backend files #16406

Closed
wants to merge 53 commits into from

Conversation

IamEzio
Copy link
Contributor

@IamEzio IamEzio commented Oct 25, 2022

Overview

  1. This PR fixes or fixes part of NA.
  2. This PR does the following: Increases branch coverage in backend files.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

Proof that changes are correct

NA

Proof of changes on desktop with slow/throttled network

NA

Proof of changes on mobile phone

NA

Proof of changes in Arabic language

NA

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL". Oppiabot will help assign that person for you.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.
  • Some of the e2e tests are flaky, and can fail for reasons unrelated to your PR. We are working on fixing this, but in the meantime, if you need to restart the tests, please check the "If your build fails" wiki page.

@oppiabot
Copy link

oppiabot bot commented Oct 26, 2022

Hi @IamEzio, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

@oppiabot oppiabot bot added the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Oct 28, 2022
@oppiabot
Copy link

oppiabot bot commented Oct 28, 2022

Hi @IamEzio, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

@oppiabot oppiabot bot added PR: don't merge - HAS MERGE CONFLICTS and removed PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. labels Oct 28, 2022
@oppiabot
Copy link

oppiabot bot commented Oct 28, 2022

Hi @IamEzio. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@oppiabot
Copy link

oppiabot bot commented Nov 14, 2022

Hi @IamEzio, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

@oppiabot oppiabot bot removed the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Nov 17, 2022
@vojtechjelinek vojtechjelinek removed their assignment Nov 17, 2022
@oppiabot oppiabot bot added the PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. label Nov 19, 2022
@oppiabot
Copy link

oppiabot bot commented Nov 19, 2022

Hi @IamEzio, the build of this PR is stale and this could result in tests failing in develop. Please update this pull request with the latest changes from develop. Thanks!

@oppiabot
Copy link

oppiabot bot commented Nov 26, 2022

Hi @IamEzio, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot
Copy link

oppiabot bot commented Nov 28, 2022

Hi @IamEzio, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

@oppiabot
Copy link

oppiabot bot commented Nov 28, 2022

Hi @IamEzio, there is a new change in develop which needs to be in your PR. Please update your branch with the latest changes in develop. For instructions, refer to this link. Thanks!

@gp201
Copy link
Member

gp201 commented Nov 29, 2022

@vojtechjelinek PTAL
Looks like @IamEzio requested a review

@vojtechjelinek
Copy link
Member

@gp201 There is one comment of mine that is not replied to #16406 (comment) so I cannot really review this.

@vojtechjelinek vojtechjelinek removed their assignment Nov 29, 2022
@oppiabot
Copy link

oppiabot bot commented Dec 6, 2022

Hi @IamEzio, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label Dec 6, 2022
@gp201
Copy link
Member

gp201 commented Dec 6, 2022

@IamEzio can you please reply to all the comments?

@oppiabot oppiabot bot removed the stale label Dec 6, 2022
@gp201
Copy link
Member

gp201 commented Dec 6, 2022

@IamEzio I'm removing LGTM label since you have some comments you have to resolve.

@oppiabot
Copy link

oppiabot bot commented Dec 8, 2022

Hi @IamEzio. Due to recent changes in the "develop" branch, this PR now has a merge conflict. Please follow this link if you need help resolving the conflict, so that the PR can be merged. Thanks!

@oppiabot
Copy link

oppiabot bot commented Dec 15, 2022

Hi @IamEzio, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 4 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 4 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale label Dec 15, 2022
@oppiabot oppiabot bot closed this Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: don't merge - HAS MERGE CONFLICTS PR: don't merge - STALE BUILD The build on this PR is stale and should be restarted. stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants